Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings
This repository was archived by the owner on Nov 1, 2017. It is now read-only.

Fix reference to default IRC hook events.#496

Merged
izuzak merged 2 commits intomasterfromfix-reference-to-default-irc-hook-events
May 9, 2014

Conversation

@jdpace
Copy link
Contributor

IRC hooks only listen topush andpull_request events by default. This was causing confusion for users who were expecting to receiveissues events as well.

There may be a better hook to use as an example since the list of supported events for the IRC hooks varies so much from the default set.

@izuzak
Copy link
Member

I agree that this is confusing and +1 on clarifying this -- thanks for tackling this 📖,@jdpace ! 💟

I'm not that familiar with how services work so I might very well be wrong on this, but there might be confusion around what the hook listens to by default vs what it can listen to if configured manually. By default, itlistens to just thepush andpull_request events, but as far as I can tell -- itcan be configured to listen to other events as well (as perhttps://github.com/github/github-services/blob/master/CONTRIBUTING.md#other-hook-types)

If my understanding is correct, what do you think about clarifying this difference?

@jdpace
Copy link
ContributorAuthor

If my understanding is correct, what do you think about clarifying this difference?

Correct, a service may support many more events besides it's default set. Services set up via the UI only get the default set specified in the service file (orpush if not specified). It's probably worth clarifying the difference here.

@izuzak
Copy link
Member

@jdpace How about something like this:

Active hooks can be configured to trigger for one or more service supported events. In other words, the service must support listening for the event you want to trigger.

For example, the Web service supports listening for all events, while the IRC service can listen forpush,issues andpull_request events.

Each service also has a set of default events for which it listens if it isn't configured. For example, the Web service listens only forpush events by default, while the IRC service listens onpush andpull_requests events. Service hooks set up via the Webhooks UI listen only for the default set of events, but can bere-configured via the API.

Not sure if this is helpful -- I'm finding it hard to write a clear explanation. 😓

@jdpace
Copy link
ContributorAuthor

For example, the Web service supports listening for all events, while the IRC service can listen forpush,issues andpull_request events.

IRC actually supports several more than that which might lead to more confusion. Here's a couple of other popular services which only support a limited number of events:

  • Twitter -push
  • Email -public,push

Service hooks set up via the Webhooks UI listen only for the default set of events, but can be re-configured via the API.

"Webhooks UI" isn't the right term here. "UI" is more correct but might not be specific enough.

@yocopoco1
Copy link

Hallo

Von Samsung Mobile gesendet

-------- Ursprüngliche Nachricht --------
Von: Jared Pacenotifications@github.com
Datum:
An: "github/developer.github.com"developer.github.com@noreply.github.com
Cc: Maiksteppin@live.de
Betreff: Re: [developer.github.com] Fix reference to default IRC hook events. (#496)

For example, the Web service supports listening for all events, while the IRC service can listen for push, issues and pull_request events.

IRC actually supports several more than that which might lead to more confusion. Here's a couple of other popular services which only support a limited number of events:

Twitter - push
Email - public, push
Service hooks set up via the Webhooks UI listen only for the default set of events, but can be re-configured via the API.

"Webhooks UI" isn't the right term here. "UI" is more correct but might not be specific enough.


Reply to this email directly or view it on GitHub.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@izuzak
Copy link
Member

@jdpace Thanks for pointing those things out. 🙇 Here's a new version which takes those two things into account:

Active hooks can be configured to trigger for one or more service supported events. In other words, the service must support listening for the event you want to trigger.

For example, the Web service supports listening for all events, while theIRC service can listen forpush,issues,pull_request,commit_comment,pull_request_review_comment, andissue_comment events.

Each service also has a set of default events for which it listens if it isn't configured. For example, the Web service listens only forpush events by default, while the IRC service listens onpush andpull_requests events. Service hooks set up via the repository settings UI listen only for the default set of events, but can bere-configured via the API.

What do you think?

@jdpace
Copy link
ContributorAuthor

@izuzak That looks great to me 📖 ✨

@izuzak
Copy link
Member

Cool, I updated the PR with that text. 👯

izuzak added a commit that referenced this pull requestMay 9, 2014
…-eventsFix reference to default IRC hook events.
@izuzakizuzak merged commit95b1b3e intomasterMay 9, 2014
@izuzakizuzak deleted the fix-reference-to-default-irc-hook-events branchMay 9, 2014 19:29
ptoomey3 added a commit that referenced this pull requestMay 14, 2015
Oauth token deprecation migration period
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jdpace@izuzak@yocopoco1

[8]ページ先頭

©2009-2025 Movatter.jp