- Notifications
You must be signed in to change notification settings - Fork1.1k
Document headers we send to payloads#451
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Definitely the right page, but I think this deserves its own section titled "Receiving hooks" after "Delete a hook", before "Pubsubhubub". We could mention any server requirements and then just move the contents of this PR under that as "Request headers". Thoughts? |
@pengwynn Awesome, I'll take that approach. I just wanted to get the discussion going. |
content/v3/repos/hooks.md Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think these areX-GitHub-Event based onhttp://github.com/github/github-services/blob/master/lib/services/web.rb#L22
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yup, typos.
content/v3/repos/hooks.md Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I suggest a couple of small tweaks:
In order for GitHub to send Webhook payloads to your service, your server needs to be accessible from the Internet. We also highly suggest using SSL so that we can send encrypted payloads over HTTPS.
|
Document headers we send to payloads
I'm not exactly sure where these docs should go but they should gosomewhere.
Fixes github/github-services#815