@jacobbednarz Thanks! We should avoid another font stack definition though, could you look at makingthis selector less specific instead?

@tobiasahlin Can definitely give it a whirl. :)

@tobiasahlin Having a look into this, there isn't too much that can be done with that selector as it controls all the inline code styles (for lists, definition lists, etc) so it as about stripped back as I can see it continuing to work. Additionally, if I turn thep code into justcode there is apre definition further down that causes a double border on the nicely formatted code blocks as they are outputted as<pre><code>.

To tidying this up, I can remove the font stack from that selector you mentioned and into thecode block further down making it more generic which achieves the same thing as I set out to do as well as not adding another font stack.

.content .verseblock-content,.content .sectionbody .dlistdt,.contentp>tt,.contentdlcode,.contentulcode,pcode {-webkit-border-radius:3px;-moz-border-radius:3px;border-radius:3px;-moz-background-clip: padding;-webkit-background-clip: padding-box;background-clip: padding-box;border:1px solid#ccc;background-color:#f9f9f9;padding:0px3px;display: inline-block;}

and

code {white-space: nowrap;font:12px Monaco,"Courier New","DejaVu Sans Mono","Bitstream Vera Sans Mono",monospace;}

What are your thoughts on this one? Feel free to let me know if you have another way I could approach this one as I could be overlooking something here.

Hey@tobiasahlin,
Have you had a chance to review this one? Just looking for some feedback on the approach you would prefer taken for this update?

Haven't heard back around this one - do@pengwynn or@atmos mind taking a look and giving this one the yay or nay?

@jacobbednarz So sorry for completely dropping this ball. My bad.

Where are you seeingcode elements that aren't wrapped in apre? That's where they should inherit the font-stack from, and if it's missing it, it could be a markup problem, rather than a CSS problem.

@jacobbednarz So sorry for completely dropping this ball. My bad.

All good - I thought you may have been pulled onto another project and just left this little old pull request behind. 😉

Where are you seeing code elements that aren't wrapped in a pre?

Some examples are in tables (oauth/index.html#L105) and<p>'s (activity/events/types#L96)

Screenshots help. 😉

My apologies. :p Here is an example of one.

And the link -https://developer.github.com/v3/oauth/ to a page with some more examples.

@jacobbednarz Nicely spotted! Looking at the current font stack, it's a bit arbitrary. Would you mind changing it to be identical to github.com? I.e.Consolas, 'Liberation Mono', Courier, monospace;. Both for thepreselector, thecode selector that you expanded, and the…, p code selector that you mentioned above.

With that in, I'd be happy to merge this

Thanks@tobiasahlin! Can you just check that commit10d0f78 is what you are after?

@jacobbednarz Looks great apart from my comment!

@jacobbednarz Thanks! ✨ 💎

Awesome! Thanks for the feedback and help with getting this one out 🍰