This repository was archived by the owner on Nov 1, 2017. It is now read-only.
- Notifications
You must be signed in to change notification settings - Fork1.1k
Update the parsing of JSON-P callback example#426
Merged
gjtorikian merged 1 commit intogithub:masterfromjacobbednarz:fix-parsing-for-jsonp-callback-exampleFeb 12, 2014
Merged
Update the parsing of JSON-P callback example#426
gjtorikian merged 1 commit intogithub:masterfromjacobbednarz:fix-parsing-for-jsonp-callback-exampleFeb 12, 2014
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
The current parsing of the JSON-P example is broken (presumable due to the JS)and to resolve it, the code just needs to be treated as regular markdown codeand not the specific code classes.
gjtorikian added a commit that referenced this pull requestFeb 12, 2014
…ack-exampleUpdate the parsing of JSON-P callback example
Contributor
gjtorikian commentedFeb 12, 2014
Thank you! ❤️ |
hubot pushed a commit that referenced this pull requestJan 19, 2015
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current parsing of the JSON-P example is broken (presumable due to the JS) and to resolve it, the code just needs to be treated as regular markdown code and not the specific code classes.
I omitted the
static/search-index.jsonfile from this commit as I would assume that is done on deployment but I can commit it up should it be needed.