Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings
This repository was archived by the owner on Nov 1, 2017. It is now read-only.

Assignees rename fields#1076

Merged

Conversation

Shredder121
Copy link
Contributor

I saw that the original user was not in theassignees list, and that the users in theassignees list weren't consistent.
This updates (merges) theUSER with itself, updating all fields with the block. (if anyone knows of a nicer way, let me know)
This makes the data a little more realistic.

@MikeMcQuaid
Copy link
Contributor

@gjtorikian Any thoughts here?

@gjtorikian
Copy link
Contributor

It's definitely clever, but I think we should just opt for explicitness.@Shredder121, would you mind simply copying theUSER constant and naming itHUBOT, and just manually replacing the words withhubot? That would allow us to use these other users in the future. Thank you!

@Shredder121
Copy link
ContributorAuthor

Should I also use the values fromhttps://api.github.com/users/hubot?

@Shredder121
Copy link
ContributorAuthor

And what aboutother_user?

@gjtorikian
Copy link
Contributor

@Shredder121 Nah, you can keep thehubot stuff much simpler, no need to actually add all the repositories and what not. Same withother_user, just copy the same stuff inUSER and replace the username.

This introduces new constants, so that they can be used in otherplaces as well.This makes the data a little more realistic.
@Shredder121Shredder121force-pushed theassignees-rename-fields branch from9316208 toaae43caCompareJune 16, 2016 07:16
@Shredder121
Copy link
ContributorAuthor

There, how's that?

@Shredder121
Copy link
ContributorAuthor

What happened to Travis?
https://travis-ci.org/github/developer.github.com

@MikeMcQuaid
Copy link
Contributor

@Shredder121 not sure but reactivated it now.

@gjtorikian
Copy link
Contributor

Beautiful. Thanks as always@Shredder121!

@gjtorikiangjtorikian merged commitc4f3fcd intogithub:masterJun 16, 2016
@Shredder121
Copy link
ContributorAuthor

Haha, no problem as always! 👍

@Shredder121Shredder121 deleted the assignees-rename-fields branchJune 16, 2016 19:33
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@Shredder121@MikeMcQuaid@gjtorikian
[8]ページ先頭
©2009-2025 Movatter.jp