This repository was archived by the owner on Nov 1, 2017. It is now read-only.
- Notifications
You must be signed in to change notification settings - Fork1.1k
GPG Keys documentation specify multiple potential Accept values#1074
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
84bb8fa to3f40d00CompareMember
izuzak commentedJun 7, 2016
Looks good to me 👍 |
Contributor
MikeMcQuaid commentedJun 15, 2016
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@alfhenrik pointed out over inthis issue that the preview headers for GPG Keys are not consistent:
application/vnd.github.cryptographer-previewas perthe announcement blog postapplication/vnd.github.cryptographer-preview+shaas perthe current docsI tested both values with a valid token and they fine, but this PR normalizes the docs to use
application/vnd.github.cryptographer-previewto be consistent with most of our other preview APIs.Let me know if anything is unclear here.