Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings
This repository was archived by the owner on Nov 1, 2017. It is now read-only.

Update issue.md#1064

Merged
gjtorikian merged 3 commits intogithub:masterfromjbottigliero:master
Apr 27, 2016
Merged

Update issue.md#1064

gjtorikian merged 3 commits intogithub:masterfromjbottigliero:master
Apr 27, 2016

Conversation

jbottigliero
Copy link
Contributor

Updates issue.md examples to be a bit more obvious due to the default value of thefilter parameter.

Updates issue.md examples to be a bit more obvious due to the default value of the `filter` parameter.
@gjtorikian
Copy link
Contributor

Thanks for this PR. I think the changes on lines 28 and 32 are great; however, I don't think we need to explicitly call out theGET /issues?filter=all syntax. It seems weird that none of the other query parameters are given their own call-out, and doing so would be too wordy anyway.

Instead, I'd suggest adding a tip block to call out this capability:

{{#tip}}You can use the `filter` query parameter to fetch issues that are not necessarily assigned to you. See the table below for more information.{{/tip}}

Joe Bottigliero added2 commitsApril 27, 2016 16:49
Removes `?filter` from examples, adds a `{{#tip}}` to point people in the right direction.
@jbottigliero
Copy link
ContributorAuthor

@gjtorikian I've updated the PR with some copy tweaks, and have removed the mention offilter in the examples (using yourtip now as well). Initially, I had attempted to make the original wording ring true... but agree it got a bit wordy.

@gjtorikian
Copy link
Contributor

Looks wonderful. Thanks!

@gjtorikiangjtorikian merged commita90d289 intogithub:masterApr 27, 2016
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@jbottigliero@gjtorikian

[8]ページ先頭

©2009-2025 Movatter.jp