Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings
This repository was archived by the owner on Nov 1, 2017. It is now read-only.

incorrect key for commit head#1056

Merged
davidcelis merged 1 commit intogithub:masterfromstevepeak:patch-1
Apr 24, 2016
Merged

incorrect key for commit head#1056

davidcelis merged 1 commit intogithub:masterfromstevepeak:patch-1
Apr 24, 2016

Conversation

stevepeak
Copy link
Contributor

@stevepeakstevepeak commentedApr 24, 2016
edited
Loading

Let me know if an example is necessary. Thanks!

{"after":"6b3d35683e4358345bc42981e0105e8ecf398b62","base_ref":null,"before":"58ac6bd52c6af71d5b77fda4d3a8d59fa70e103d","commits": [...

No "head" key found in the body.

@davidcelis
Copy link
Contributor

Let me know if an example is necessary.

Not at all necessary 😄 I can see in some of our ownPushEvent payloads that you definitely caught a mistake. Thank you,@stevepeak!

stevepeak reacted with thumbs up emoji

@davidcelisdavidcelis merged commitf887199 intogithub:masterApr 24, 2016
@Shredder121
Copy link
Contributor

This is a recurring issue right?
It's already documented, or am I missing something?
head should beafter in PushEvent #966

@davidcelis
Copy link
Contributor

You're right, I mistook which payload was being edited. Thanks for the catch,@Shredder121.

@davidcelis
Copy link
Contributor

davidcelis commentedApr 24, 2016
edited
Loading

@stevepeak Sorry for the confusion, I've reverted this PR. The PushEvent payload in the API and the webhook payload don't match. This is unfortunately confusing, but has to remain true for backwards compatibility. There's a note that denotes this inthe docs:

The Events API PushEvent payload is described in the table below. The example payload below that is from a webhook delivery and will differ from the Events API PushEvent payload.

I accidentally mentally flip-flopped which payload you were editing, hence the confusion. Sorry again!

@stevepeak
Copy link
ContributorAuthor

No worries :) Thank you!

Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@stevepeak@davidcelis@Shredder121

[8]ページ先頭

©2009-2025 Movatter.jp