- Notifications
You must be signed in to change notification settings - Fork10
fix: typo in "failure_reaction"#78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull Request Overview
This PR fixes a typo where the reaction input key was incorrectly named "failed_reaction" instead of "failure_reaction", ensuring consistency with the repository's README.
- Fixed the reaction input key for the failure condition in the post function.
- Updated tests to verify the correct reaction is used on both success and failure outcomes.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/functions/post.js | Renamed input from "failed_reaction" to "failure_reaction" |
| tests/functions/post.test.js | Added tests to check the updated behavior for reaction inputs |
@GrantBirki Could you please review this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks great, thank you!
0821dfd intogithub:mainUh oh!
There was an error while loading.Please reload this page.
A new release, |
@GrantBirki |
close#77
The repository's README says "failure_reaction", but the source code uses "failed_reaction". This PR fixes this to use "failure_reaction" and adds tests.