- Notifications
You must be signed in to change notification settings - Fork68
Implement most of Classes2, split out two harder rules#948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull Request Overview
This PR implements most of the Classes2 rule package by adding 6 new C++ MISRA rule queries, while moving 2 harder rules (RULE-15-0-1 and RULE-15-1-4) to Classes3 package. The implementation includes comprehensive test coverage and proper integration with the exclusion framework.
- Adds 6 new MISRA C++ 2023 rule implementations covering virtual inheritance, member specifiers, data member access levels, special member functions, conversion operators, and operator overloading
- Moves 2 complex rules to Classes3 package for future implementation
- Creates comprehensive test suites with both compliant and non-compliant examples for each rule
Reviewed Changes
Copilot reviewed 32 out of 32 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| rules.csv | Updates rule assignments, moving RULE-15-0-1 and RULE-15-1-4 to Classes3 package |
| rule_packages/cpp/Classes2.json | Defines metadata for 6 implemented MISRA rules in Classes2 package |
| cpp/misra/test/rules/RULE-*/test.cpp | Test files providing comprehensive coverage for each rule implementation |
| cpp/misra/test/rules/RULE-/.qlref | Reference files linking to query implementations |
| cpp/misra/test/rules/RULE-/.expected | Expected test results for validation |
| cpp/misra/src/rules/RULE-/.ql | Query implementations for each MISRA rule |
| cpp/common/src/codingstandards/cpp/exclusions/cpp/RuleMetadata.qll | Integration with exclusion framework |
| cpp/common/src/codingstandards/cpp/exclusions/cpp/Classes2.qll | Auto-generated exclusion definitions for Classes2 package |
Comments suppressed due to low confidence (1)
cpp/misra/src/rules/RULE-14-1-1/PrivateAndPublicDataMembersMixed.ql:1
- Spelling error: 'maintanability' should be 'maintainability'.
/**Tip: Customize your code reviews with copilot-instructions.md.Create the file orlearn how to get started.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Description
Implement Classes2 package, except for RULE-15-0-1 (which has tricky information missing from the database) and RULE-15-1-4 (which I haven't started yet but will take many hours).
Change request type
.ql,.qll,.qlsor unit tests)Rules with added or modified queries
RULE-13-1-1RULE-13-3-1RULE-14-1-1RULE-15-0-2RULE-15-1-3RULE-16-5-1RULE-16-6-1Release change checklist
A change note (development_handbook.md#change-notes) is required for any pull request which modifies:
If you are only adding new rule queries, a change note is not required.
Author: Is a change note required?
🚨🚨🚨
Reviewer: Confirm that format ofshared queries (not the .qll file, the
.ql file that imports it) is valid by running them within VS Code.
Reviewer: Confirm that either a change note is not required or the change note is required and has been added.
Query development review checklist
For PRs that add new queries or modify existing queries, the following checklist should be completed by both the author and reviewer:
Author
As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.
Reviewer
As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.