- Notifications
You must be signed in to change notification settings - Fork70
Upgradegithub/codeql dependency to 2.20.7#913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Update queries after `TemplateParameter` deprecation
Update A2-10-4 after QL changes
Contributor
lcartey commentedJun 19, 2025
/test-performance |
Author
🏁 Beep Boop! Performance testing for this PR has been initiated. Please check back later for results. Note that the query package generation step must complete before testing will start so it might be a minute. |
🏁 Beep Boop! Performance testing complete! See below for performance of the last 3 runs vs your PR. Times are based on predicate performance. You canfind full graphs and stats in the PR that was created for this test in the release engineering repo. 🏁 Below are the slowest predicates for the last 2 releases vs this PR. |
Collaborator
MichaelRFairhurst commentedJun 19, 2025
Seems like a fairly large performance regression. I am happy to take a look at the compatible types predicate and the integer constant macro predicate performance. |
…nteger constant macros
…es-upgrading-to-2.20.7Fix bad joins on function names and unnecessarily large relation on integer constant macros
Collaborator
MichaelRFairhurst commentedJul 16, 2025
/test-performance |
Author
🏁 Beep Boop! Performance testing for this PR has been initiated. Please check back later for results. Note that the query package generation step must complete before testing will start so it might be a minute. |
🏁 Beep Boop! Performance testing complete! See below for performance of the last 3 runs vs your PR. Times are based on predicate performance. You canfind full graphs and stats in the PR that was created for this test in the release engineering repo. 🏁 Below are the slowest predicates for the last 2 releases vs this PR. |
Collaborator
MichaelRFairhurst commentedJul 16, 2025
Still a fair performance regression in cpp, from 2837 to 3299 seconds. That ~450 sec delay is not entirely explained by the slowest predicates highlighted:
Totals to 289s by themselves alone, ignoring that they really need to be compared to the slowest predicates from the previous release. We'll need to rely on the data pushed up to the release engineering branch and expect maybe a few rounds of getting this down. |
Poor join ordering on locations.
- Only consider declarations within user code - as results in system headers will be thrown away, and significantly bloat the interemediate relation sizes. - Inline the function scope exclusion to documentable declaration. - Extract utility predicates for determining if there's a documented definition, or whether there are only definitions.
Avoid cross-product on function.
Contributor
lcartey commentedJul 18, 2025
/test-performance |
Author
🏁 Beep Boop! Performance testing for this PR has been initiated. Please check back later for results. Note that the query package generation step must complete before testing will start so it might be a minute. |
🏁 Beep Boop! Performance testing complete! See below for performance of the last 3 runs vs your PR. Times are based on predicate performance. You canfind full graphs and stats in the PR that was created for this test in the release engineering repo. 🏁 Below are the slowest predicates for the last 2 releases vs this PR. |
Contributor
lcartey commentedJul 18, 2025
@MichaelRFairhurst I've made some further performance improvements, and it looks like we've now addressed the main issues - performance for both C and C++ is now below the 2.48.0 release. |
MichaelRFairhurst requested changesJul 18, 2025
Collaborator
MichaelRFairhurst left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nice! Awesome to see performance improved overall for both standards now.
Should this also have a change note?
...llthemselveseitherdirectlyorindirectly/FunctionsCallThemselvesEitherDirectlyOrIndirectly.qllShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
MichaelRFairhurst approved these changesJul 31, 2025
Collaborator
MichaelRFairhurst left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Approved per offline discussion (no change not required)
Merged via the queue intomain with commitJul 31, 2025
950c719 30 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This PR upgrades the CodeQL CLI version to 2.20.7.
CodeQL dependency upgrade checklist:
github/codeqltest cases succeed.github/codeql-coding-standardsrepository.