- Notifications
You must be signed in to change notification settings - Fork67
Fix poor performance of sameSource predicate#907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull Request Overview
This PR addresses performance issues in thesameSource predicate by preventing premature inlining and constraining its bindings.
- Switches from
inlinetoinline_lateto avoid heavy common-subexpression expansion - Adds a
bindingset[a, b]directive to limit predicate instantiations
Comments suppressed due to low confidence (1)
cpp/common/src/codingstandards/cpp/rules/iofstreammissingpositioning/IOFstreamMissingPositioning.qll:54
- [nitpick] Consider adding a comment above this pragma to explain that
inline_lateis used to prevent early inlining and avoid expensive common-subexpression optimizations that degrade performance.
pragma[inline_late]...on/src/codingstandards/cpp/rules/iofstreammissingpositioning/IOFstreamMissingPositioning.qllShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
1d2a7f2 to985a2d1Compare/test-performance |
🏁 Beep Boop! Performance testing for this PR has been initiated. Please check back later for results. Note that the query package generation step must complete before testing will start so it might be a minute. |
🏁 Beep Boop! Performance testing complete! See below for performance of the last 3 runs vs your PR. Times are based on predicate performance. You canfind full graphs and stats in the PR that was created for this test in the release engineering repo. 🏁 Below are the slowest predicates for the last 2 releases vs this PR. |
Performance results appear reasonable to me. |
lcartey approved these changesJun 6, 2025
Merged via the queue intogithub:main with commitJun 6, 2025
42985d7 21 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Thank you@smowton ! 🎉 🎉 🎉 |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Description
User atgithub/codeql#19633 observed that
sameSourcecould be a potentially-large cost in running thecodeql/cert-c-coding-standards@2.45.0suite.I noticed that while the inline pragma made clear that the intent was never to materialise
sameSourcein its entirety but rather only to identify if two file-accesses referred to the same source once the two candidates had been otherwise constrained, in practice a common-subexpression pass was lifting the general square of all possibly-aliasing file accesses into a#sharedpredicate.Switching to
inline_lateinstead defeats this potential misoptimisation, and at least for the linked discussion makes the suite once again run on a practical timescale.Change request type
.ql,.qll,.qlsor unit tests)Rules with added or modified queries
FIO39-CFIO50-CPPA27-0-3RULE-30-0-2Release change checklist
A change note (development_handbook.md#change-notes) is required for any pull request which modifies:
If you are only adding new rule queries, a change note is not required.
Author: Is a change note required?
🚨🚨🚨
Reviewer: Confirm that format ofshared queries (not the .qll file, the
.ql file that imports it) is valid by running them within VS Code.
Reviewer: Confirm that either a change note is not required or the change note is required and has been added.
Query development review checklist
For PRs that add new queries or modify existing queries, the following checklist should be completed by both the author and reviewer:
Author
As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.
Reviewer
As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.