Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

A2-10-5: Exclude variables in template instantiations#64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
lcartey merged 5 commits intogithub:mainfromlcartey:lcartey/a2-10-5-templates
Sep 30, 2022
Merged
Show file tree
Hide file tree
Changes fromall commits
Commits
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletionschange_notes/2022-08-18-variable-templates-reused-name.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
- `A2-10-5` - `IdentifierNameOfANonMemberObjectWithExternalOrInternalLinkageIsReused.ql`
- Reduce false positives by excluding variable template instantiations.
Original file line numberDiff line numberDiff line change
Expand Up@@ -32,7 +32,11 @@ where
not isExcluded(o2,
NamingPackage::identifierNameOfANonMemberObjectWithExternalOrInternalLinkageIsReusedQuery()) and
not o1 = o2 and
o1.getName() = o2.getName()
o1.getName() = o2.getName() and
// Only consider variables from uninstantiated templates, to avoid false positives where o1 and
// o2 are the same object across different template instantiations
not o1.isFromTemplateInstantiation(_) and
not o2.isFromTemplateInstantiation(_)
select o2,
"Identifier name of non-member object $@ reuses the identifier name of non-member object $@.", o2,
o2.getName(), o1, o1.getName()
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,4 @@
| test1a.cpp:6:12:6:13 | g3 | Identifier name of non-member object $@ reuses the identifier name of non-member object $@. | test1a.cpp:6:12:6:13 | g3 | g3 | test1b.cpp:7:12:7:13 | g3 | g3 |
| test1a.cpp:17:43:17:43 | number_two | Identifier name of non-member object $@ reuses the identifier name of non-member object $@. | test1a.cpp:17:43:17:43 | number_two | number_two | test1b.cpp:12:43:12:43 | number_two | number_two |
| test1b.cpp:7:12:7:13 | g3 | Identifier name of non-member object $@ reuses the identifier name of non-member object $@. | test1b.cpp:7:12:7:13 | g3 | g3 | test1a.cpp:6:12:6:13 | g3 | g3 |
| test1b.cpp:12:43:12:43 | number_two | Identifier name of non-member object $@ reuses the identifier name of non-member object $@. | test1b.cpp:12:43:12:43 | number_two | number_two | test1a.cpp:17:43:17:43 | number_two | number_two |
14 changes: 14 additions & 0 deletionscpp/autosar/test/rules/A2-10-5/test1a.cpp
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,3 +5,17 @@ static int g1 = 0;
static int g2; // COMPLIANT
static int g3 = 1; // NON_COMPLIANT
static void f1(){}; // NON_COMPLIANT

// Variable template has multiple declarations: one for the uninstantiated
// template and one for each instantiation
template <class T> constexpr T number_one = T(1); // COMPLIANT

int test() { return number_one<int>; }

long test2() { return number_one<long>; }

template <class T> constexpr T number_two = T(1); // NON_COMPLIANT

int test3() { return number_two<int>; }

long test4() { return number_two<long>; }
6 changes: 6 additions & 0 deletionscpp/autosar/test/rules/A2-10-5/test1b.cpp
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -8,3 +8,9 @@ static int g3 = 0; // NON_COMPLIANT
}

static void f1() {} // NON_COMPLIANT

template <class T> constexpr T number_two = T(1); // NON_COMPLIANT

int test3() { return number_two<int>; }

long test4() { return number_two<long>; }
[8]ページ先頭
©2009-2025 Movatter.jp