Description

• Introduced MISRA C++ 2023 Import rules.
• Updated the.json files for rule packages.
• Aligned tests cases.
• Enhanced the cpp standard-library headers to apply existing c tests to new cpp queries.
• Transitioned.qll libraries to the cpp folder as needed.
• Tweaked thegenerate_package_files.py script for alignment withcodeql query format.
• Modifiedshared_library.ql.template to include a comment

Change request type

• Release or process automation (GitHub workflows, internal scripts)
• Internal documentation
• External documentation
• Query files (.ql,.qll,.qls or unit tests)
• External scripts (analysis report or other code shipped as part of a release)

Rules with added or modified queries

• No rules added
• Queries have been added for the following rules:
  • RULE-5-7-1 DIR-5-7-2 RULE-5-7-3 RULE-5-13-1 RULE-5-13-2 RULE-5-13-3 RULE-5-13-4 RULE-5-13-5 RULE-6-0-3 RULE-6-0-4 RULE-6-2-1 RULE-6-4-1 RULE-6-4-2 RULE-6-4-3 RULE-6-8-1 RULE-6-8-2 RULE-7-11-1 RULE-7-11-2 RULE-8-2-3 RULE-8-2-4 RULE-8-2-5 RULE-8-2-10 RULE-8-3-1 RULE-8-18-2 RULE-8-19-1 RULE-8-20-1 RULE-9-3-1 RULE-9-4-1 RULE-9-6-1 RULE-9-6-2 RULE-9-6-3 RULE-9-6-4 RULE-9-6-5 RULE-10-0-1 RULE-10-2-1 RULE-10-4-1 RULE-11-3-2 RULE-11-6-3 RULE-12-2-2 RULE-12-2-3 RULE-13-1-2 RULE-13-3-2 RULE-13-3-4 RULE-15-1-1 RULE-15-1-2 RULE-15-1-5 DIR-15-8-1 RULE-16-5-2 RULE-17-8-1 RULE-18-1-1 RULE-18-1-2 RULE-18-3-3 RULE-18-5-1 RULE-19-0-2 RULE-19-0-3 RULE-19-1-3 RULE-19-2-3 RULE-19-3-1 RULE-19-3-2 RULE-19-3-3 RULE-19-3-5 RULE-21-2-1 RULE-21-2-4 RULE-21-6-4 RULE-21-6-5 RULE-21-10-3 RULE-25-5-2 RULE-25-5-3 RULE-26-3-1 RULE-28-6-2 RULE-28-6-3 RULE-30-0-1 RULE-30-0-2
• Queries have been modified for the following rules:
  • M2-7-1 A2-7-2 A2-7-1 A2-13-1 RULE-4-1 M2-13-2 M2-13-3 RULE-7-3 M7-3-1 M7-3-2 M3-2-2 A2-10-1 A7-3-1 M14-6-1 A3-8-1 M7-5-1 A4-10-1 M5-2-12 A5-2-3 M5-2-6 A5-2-4 A7-5-2 M5-3-2 RULE-13-4 M5-18-1 INT30-C RULE-15-6 RULE-15-7 RULE-15-1 RULE-15-3 RULE-15-2 MSC53-CPP MSC52-CPP M8-0-1 A7-2-2 A7-4-1 A5-0-3 RULE-8-12 RULE-6-1 M9-6-4 M10-1-3 M8-3-1 A5-10-1 M12-1-1 A12-1-1 A8-5-4 A12-8-5 M5-3-3 A14-8-2 A15-1-2 M15-1-3 M15-3-3 A15-4-2 DIR-4-9 RULE-20-1 M16-0-7 A16-2-1 M16-3-2 RULE-20-11 RULE-20-12 RULE-20-6 RULE-21-7 M18-2-1 A18-5-4 A5-3-3 M18-7-1 RULE-21-19 RULE-21-20 A18-1-2 A18-9-2 A12-8-3 M27-0-1 A27-0-3

Release change checklist

A change note (development_handbook.md#change-notes) is required for any pull request which modifies:

• The structure or layout of the release artifacts.
• The evaluation performance (memory, execution time) of an existing query.
• The results of an existing query in any circumstance.

If you are only adding new rule queries, a change note is not required.

Author: Is a change note required?

• Yes
• No

🚨🚨🚨
Reviewer: Confirm that format ofshared queries (not the .qll file, the
.ql file that imports it) is valid by running them within VS Code.

• Confirmed

Reviewer: Confirm that either a change note is not required or the change note is required and has been added.

• Confirmed

Query development review checklist

For PRs that add new queries or modify existing queries, the following checklist should be completed by both the author and reviewer:

Author

• Have all the relevant rule package description files been checked in?
• Have you verified that the metadata properties of each new query is set appropriately?
• Do all the unit tests contain both "COMPLIANT" and "NON_COMPLIANT" cases?
• Are the alert messages properly formatted and consistent with thestyle guide?
• Have you run the queries on OpenPilot and verified that the performance and results are acceptable?
  As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.
• Does the query have an appropriate level of in-query comments/documentation?
• Have you considered/identified possible edge cases?
• Does the query not reinvent features in the standard library?
• Can the query be simplified further (not golfed!)

Reviewer

• Have all the relevant rule package description files been checked in?
• Have you verified that the metadata properties of each new query is set appropriately?
• Do all the unit tests contain both "COMPLIANT" and "NON_COMPLIANT" cases?
• Are the alert messages properly formatted and consistent with thestyle guide?
• Have you run the queries on OpenPilot and verified that the performance and results are acceptable?
  As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.
• Does the query have an appropriate level of in-query comments/documentation?
• Have you considered/identified possible edge cases?
• Does the query not reinvent features in the standard library?
• Can the query be simplified further (not golfed!)