- Notifications
You must be signed in to change notification settings - Fork70
Modernize dataflow configurations#468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
67ab0aa toef99cccComparec/cert/src/rules/EXP36-C/DoNotCastPointerToMoreStrictlyAlignedPointerType.ql OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
…PointerType.qlCo-authored-by: Anders Schack-Mulligen <aschackmull@users.noreply.github.com>
aschackmull approved these changesDec 4, 2023
Contributor
aschackmull left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
QL changes LGTM. I did not look at the expected-file changes.
Contributor
aschackmull commentedDec 7, 2023
I expect the test differences to mostly be due togithub/codeql#13717 |
Contributor
lcartey commentedDec 7, 2023
/performance-test |
Contributor
jsinglet commentedDec 7, 2023
/test-performance |
🏁 Beep Boop! Performance testing for this PR has been initiated. Please check back later for results. Note that the query package generation step must complete before testing will start so it might be a minute. |
Contributor
jsinglet commentedDec 7, 2023
🏁 Beep Boop! Performance testing complete! See below for performance of the last 3 runs vs your PR. Times are based on predicate performance. You canfind full graphs and stats in the PR that was created for this test in the release engineering repo. 🏁 Below are the slowest predicates for the last 2 releases vs this PR. |
Contributor
lcartey commentedDec 8, 2023
/test-matrix |
🤖 Beep Boop! Matrix Testing for this PR has been initiated. Please check back later for results. |
Contributor
jsinglet commentedDec 8, 2023
🤖 Beep Boop!qcc/cpp/AARCH64LE Matrix Testing for this PR won't happen because it is outside of license window! |
Contributor
jsinglet commentedDec 8, 2023
🤖 Beep Boop!qcc/c/AARCH64LE Matrix Testing for this PR won't happen because it is outside of license window! |
Contributor
jsinglet commentedDec 8, 2023
🤖 Beep Boop!clang/cpp/X86_64 Matrix Testing for this PR has been completed. See below for the results! |
Contributor
jsinglet commentedDec 8, 2023
🤖 Beep Boop!gcc/cpp/X86_64 Matrix Testing for this PR has been completed. See below for the results! |
Contributor
jsinglet commentedDec 8, 2023
🤖 Beep Boop!clang/c/X86_64 Matrix Testing for this PR has been completed. See below for the results! |
Contributor
jsinglet commentedDec 8, 2023
🤖 Beep Boop!gcc/c/X86_64 Matrix Testing for this PR has been completed. See below for the results! |
Contributor
jsinglet commentedDec 8, 2023
🤖 Beep Boop! Matrix Testing for this PR has beencompleted. If no reports were posted it means this PR does not contain things that need matrix testing! |
lcartey approved these changesDec 8, 2023
Contributor
lcartey left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks for updating this!
I believe the main user-facing impact for this change is the addition of intermediate nodes in path results where those nodes were specified as additional flow edges (seegithub/codeql#13717). Reviewing the test changes, I think this should be an improvement overall.
No significant performance changes identified, and no observed compiler compatibility issues in the changed queries. We may still see some compiler compatibility issues based on changes to shared libraries, but these can be addressed as part of the wider group of compiler compatibility issues.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Description
Note that this targets
main. Let me know if retargeting tonextmakes more sense.The
DataFlow::ConfigurationandTaintTracking::Configurationclasses are going to be deprecated soon. Modernize the queries that use these by switching them over to the newDataFlow::ConfigSig.This should not affect performance, but it's probably still good to test this. There are also some small changes to some of the paths in the test results. These look correct to me.
While doing this work, made the naming of the configurations more consistent. They now all end in
Config.Change request type
.ql,.qll,.qlsor unit tests)Rules with added or modified queries
Release change checklist
A change note (development_handbook.md#change-notes) is required for any pull request which modifies:
If you are only adding new rule queries, a change note is not required.
Author: Is a change note required?
🚨🚨🚨
Reviewer: Confirm that format ofshared queries (not the .qll file, the
.ql file that imports it) is valid by running them within VS Code.
Reviewer: Confirm that either a change note is not required or the change note is required and has been added.
Query development review checklist
For PRs that add new queries or modify existing queries, the following checklist should be completed by both the author and reviewer:
Author
As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.
Reviewer
As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.