- Notifications
You must be signed in to change notification settings - Fork70
Fix issues with c/qcc compatibility#289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
RULE-21-4 `setjmp` and `longjmp` can be macros or functions
library can access `stdin` or `_Stdin` by reference
Add support for alternative NULL pointer definition
- removed links to library internals- documented false positives due to extractor errors
Contributor
jsinglet commentedApr 24, 2023
🤖 Beep Boop!qcc/c/aarch64le Matrix Testing for this PR has been completed. See below for the results! |
jsinglet approved these changesApr 24, 2023
Contributor
jsinglet left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks good@mbaluda! Should we perhaps be keeping track of how many were simple path/library issues vs which required deeper work?
ContributorAuthor
mbaluda commentedApr 24, 2023
I split the description in 2 parts: fixes to the queries vs adjustment to test files |
Fix test files for RULE-1-3 and CON38-C
Contributor
jsinglet commentedApr 26, 2023
🤖 Beep Boop!clang/c/x86_64 Matrix Testing for this PR has been completed. See below for the results! |
ContributorAuthor
mbaluda commentedApr 26, 2023
|
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Description
Fix issues with c/qcc compatibility in the queries:
RULE-21-4:longjmpcan be a macro or a functionENV32-C: exit functions can be macros or functionsERR33-CFIO34-CFIO46-CRULE-22-6: add support forqccto library filesReadErrorsAndEOF.qllDoNotAccessAClosedFile.qllFileAccess.qllSTR37-C: add support for a differenttolower/touppermacro implementationEXP43-C: list library functions that are explicitly mentionedRULE-11-1RULE-11-2RULE-11-5: support for alternative NULL pointer definitionMinor adjustments to output, tests or
.expectedfiles:ARR39-C,CON40-C,CON41-C,ERR30-C,FIO32-C,FIO47-C,STR34-C: add.expected.qccfilesEXP39-C: add.expected.qccfile with library references in pathRULE-1-2: remove unsupported code from testsRULE-10-6: Fix output string formatSTR32-CSTR38-C: removed links to library internals, documented false positives due toextractor errorsChange request type
.ql,.qll,.qlsor unit tests)Rules with added or modified queries
Release change checklist
A change note (development_handbook.md#change-notes) is required for any pull request which modifies:
If you are only adding new rule queries, a change note is not required.
Author: Is a change note required?
🚨🚨🚨
Reviewer: Confirm that format ofshared queries (not the .qll file, the
.ql file that imports it) is valid by running them within VS Code.
Reviewer: Confirm that either a change note is not required or the change note is required and has been added.
Query development review checklist
For PRs that add new queries or modify existing queries, the following checklist should be completed by both the author and reviewer:
Author
As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.
Reviewer
As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.