- Notifications
You must be signed in to change notification settings - Fork70
Performance Hotfix for 2.15.1#261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
The calculatons for signed and unsigned type of lowest rank wereexpensive when there were a large number of constant expressions in theprogram. This commit improves performance by: 1. Creating classes to represent the set of integer constantexpressions and integer constants in the program. 2. Creating a candidate table of IntegralTypes for each known constantinteger value in the program, to avoid duplicate work. 3. Calculating the stlr and utlr for each constant value, not eachconstant expression.
This improves the performance of Rule 10.5 by computing all the types ofthe cast first, before determining whether they were invalid. Previouslythe join orderer found the essential type category of the "from" type,then joined that will invalid type categories, then joined that with allexpressions of that type before filtering down to the cast.
🤖 Beep Boop! Matrix Testing for this PR has been initiated. Please check back later for results. |
ContributorAuthor
jsinglet commentedMar 17, 2023
🤖 Beep Boop!gcc/cpp/X86_64 Matrix Testing for this PR has been completed but I didn't find anything to test! |
ContributorAuthor
jsinglet commentedMar 17, 2023
🤖 Beep Boop!clang/cpp/X86_64 Matrix Testing for this PR has been completed but I didn't find anything to test! |
ContributorAuthor
jsinglet commentedMar 17, 2023
🤖 Beep Boop!qcc/cpp/AARCH64LE Matrix Testing for this PR has been completed but I didn't find anything to test! |
ContributorAuthor
jsinglet commentedMar 17, 2023
🤖 Beep Boop!gcc/c/X86_64 Matrix Testing for this PR has been completed. See below for the results! |
ContributorAuthor
jsinglet commentedMar 17, 2023
🤖 Beep Boop!clang/c/X86_64 Matrix Testing for this PR has been completed. See below for the results! |
🤖 Beep Boop! Matrix Testing for this PR has been initiated. Please check back later for results. |
ContributorAuthor
jsinglet commentedMar 17, 2023
🤖 Beep Boop!qcc/c/AARCH64LE Matrix Testing for this PR has been completed. See below for the results! |
ContributorAuthor
jsinglet commentedMar 17, 2023
🤖 Beep Boop! Matrix Testing for this PR has beencompleted. If no reports were posted it means this PR does not contain things that need matrix testing! |
lcartey approved these changesMar 17, 2023
ContributorAuthor
jsinglet commentedMar 17, 2023
/test-performance |
🏁 Beep Boop! Performance testing for this PR has been initiated. Please check back later for results. Note that the query package generation step must complete before testing will start so it might be a minute. |
ContributorAuthor
jsinglet commentedMar 17, 2023
🤖 Beep Boop!clang/cpp/X86_64 Matrix Testing for this PR has been completed but I didn't find anything to test! |
ContributorAuthor
jsinglet commentedMar 17, 2023
🤖 Beep Boop!clang/c/X86_64 Matrix Testing for this PR has been completed. See below for the results! |
ContributorAuthor
jsinglet commentedMar 17, 2023
🤖 Beep Boop!gcc/c/X86_64 Matrix Testing for this PR has been completed. See below for the results! |
ContributorAuthor
jsinglet commentedMar 17, 2023
🤖 Beep Boop!gcc/cpp/X86_64 Matrix Testing for this PR has been completed but I didn't find anything to test! |
ContributorAuthor
jsinglet commentedMar 17, 2023
🤖 Beep Boop!qcc/cpp/AARCH64LE Matrix Testing for this PR has been completed but I didn't find anything to test! |
ContributorAuthor
jsinglet commentedMar 17, 2023
🤖 Beep Boop!qcc/c/AARCH64LE Matrix Testing for this PR has been completed. See below for the results! |
ContributorAuthor
jsinglet commentedMar 17, 2023
🤖 Beep Boop! Matrix Testing for this PR has beencompleted. If no reports were posted it means this PR does not contain things that need matrix testing! |
ContributorAuthor
jsinglet commentedMar 17, 2023
🏁 Beep Boop! Performance testing complete! See below for performance of the last 3 runs vs your PR. Times are based on predicate performance. You canfind full graphs and stats in the PR that was created for this test in the release engineering repo. 🏁 Below are the slowest predicates for the last 2 releases vs this PR. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Description
Performance Hotfix for 2.15.1.
Change request type
.ql,.qll,.qlsor unit tests)Rules with added or modified queries
Release change checklist
A change note (development_handbook.md#change-notes) is required for any pull request which modifies:
If you are only adding new rule queries, a change note is not required.
Author: Is a change note required?
🚨🚨🚨
Reviewer: Confirm that format ofshared queries (not the .qll file, the
.ql file that imports it) is valid by running them within VS Code.
Reviewer: Confirm that either a change note is not required or the change note is required and has been added.
Query development review checklist
For PRs that add new queries or modify existing queries, the following checklist should be completed by both the author and reviewer:
Author
As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.
Reviewer
As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.