Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

EssentialTypes: Improve performance.#257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jsinglet merged 4 commits intomainfromlcartey/improve-essential-type-performance
Mar 17, 2023

Conversation

@lcartey
Copy link
Contributor

Description

Address two observed performance issues with the EssentialTypes rules when run with CodeQL CLI 2.10.5.

Change request type

  • Release or process automation (GitHub workflows, internal scripts)
  • Internal documentation
  • External documentation
  • Query files (.ql,.qll,.qls or unit tests)
  • External scripts (analysis report or other code shipped as part of a release)

Rules with added or modified queries

  • No rules added
  • Queries have been added for the following rules:
    • rule number here
  • Queries have been modified for the following rules:
    • rule number here

Release change checklist

A change note (development_handbook.md#change-notes) is required for any pull request which modifies:

  • The structure or layout of the release artifacts.
  • The evaluation performance (memory, execution time) of an existing query.
  • The results of an existing query in any circumstance.

If you are only adding new rule queries, a change note is not required.

Author: Is a change note required?

  • Yes
  • No

🚨🚨🚨
Reviewer: Confirm that format ofshared queries (not the .qll file, the
.ql file that imports it) is valid by running them within VS Code.

  • Confirmed

Reviewer: Confirm that either a change note is not required or the change note is required and has been added.

  • Confirmed

Query development review checklist

For PRs that add new queries or modify existing queries, the following checklist should be completed by both the author and reviewer:

Author

  • Have all the relevant rule package description files been checked in?
  • Have you verified that the metadata properties of each new query is set appropriately?
  • Do all the unit tests contain both "COMPLIANT" and "NON_COMPLIANT" cases?
  • Are the alert messages properly formatted and consistent with thestyle guide?
  • Have you run the queries on OpenPilot and verified that the performance and results are acceptable?
    As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.
  • Does the query have an appropriate level of in-query comments/documentation?
  • Have you considered/identified possible edge cases?
  • Does the query not reinvent features in the standard library?
  • Can the query be simplified further (not golfed!)

Reviewer

  • Have all the relevant rule package description files been checked in?
  • Have you verified that the metadata properties of each new query is set appropriately?
  • Do all the unit tests contain both "COMPLIANT" and "NON_COMPLIANT" cases?
  • Are the alert messages properly formatted and consistent with thestyle guide?
  • Have you run the queries on OpenPilot and verified that the performance and results are acceptable?
    As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.
  • Does the query have an appropriate level of in-query comments/documentation?
  • Have you considered/identified possible edge cases?
  • Does the query not reinvent features in the standard library?
  • Can the query be simplified further (not golfed!)

@lcarteylcartey requested a review fromjsingletMarch 16, 2023 18:09
@github-actions
Copy link

🤖 Beep Boop! Matrix Testing for this PR has been initiated. Please check back later for results.

💡 If you do not hear back from me please check my status!I will report even if this PR does not contain files eligible for matrix testing.

@jsinglet
Copy link
Contributor

🤖 Beep Boop!clang/cpp/X86_64 Matrix Testing for this PR has been completed but I didn't find anything to test!

@jsinglet
Copy link
Contributor

🤖 Beep Boop!gcc/c/X86_64 Matrix Testing for this PR has been completed. See below for the results!

QUERY                : InappropriateEssentialTypeCastSUITE                : MISRA-C-2012COMPILE_ERROR_OUTPUT : TEST_DIFFERENCE      : TEST_PASS            : TrueCOMPILE_PASS         : TrueRULE                 : RULE-10-5PACKAGE              : EssentialTypes

@jsinglet
Copy link
Contributor

🤖 Beep Boop!clang/c/X86_64 Matrix Testing for this PR has been completed. See below for the results!

SUITE                : MISRA-C-2012COMPILE_ERROR_OUTPUT : PACKAGE              : EssentialTypesTEST_DIFFERENCE      : TEST_PASS            : TrueRULE                 : RULE-10-5COMPILE_PASS         : TrueQUERY                : InappropriateEssentialTypeCast

@github-actions
Copy link

🤖 Beep Boop! Matrix Testing for this PR has been initiated. Please check back later for results.

💡 If you do not hear back from me please check my status!I will report even if this PR does not contain files eligible for matrix testing.

@jsinglet
Copy link
Contributor

🤖 Beep Boop!gcc/cpp/X86_64 Matrix Testing for this PR has been completed but I didn't find anything to test!

@jsinglet
Copy link
Contributor

🤖 Beep Boop!qcc/cpp/AARCH64LE Matrix Testing for this PR has been completed but I didn't find anything to test!

@jsinglet
Copy link
Contributor

🤖 Beep Boop!clang/cpp/X86_64 Matrix Testing for this PR has been completed but I didn't find anything to test!

@jsinglet
Copy link
Contributor

🤖 Beep Boop!gcc/cpp/X86_64 Matrix Testing for this PR has been completed but I didn't find anything to test!

@jsinglet
Copy link
Contributor

🤖 Beep Boop!gcc/c/X86_64 Matrix Testing for this PR has been completed. See below for the results!

SUITE                : MISRA-C-2012TEST_PASS            : TrueCOMPILE_ERROR_OUTPUT : TEST_DIFFERENCE      : RULE                 : RULE-10-5QUERY                : InappropriateEssentialTypeCastCOMPILE_PASS         : TruePACKAGE              : EssentialTypes

@jsinglet
Copy link
Contributor

🤖 Beep Boop!clang/c/X86_64 Matrix Testing for this PR has been completed. See below for the results!

PACKAGE              : EssentialTypesTEST_PASS            : TrueRULE                 : RULE-10-5TEST_DIFFERENCE      : QUERY                : InappropriateEssentialTypeCastSUITE                : MISRA-C-2012COMPILE_ERROR_OUTPUT : COMPILE_PASS         : True

@jsinglet
Copy link
Contributor

🤖 Beep Boop!qcc/cpp/AARCH64LE Matrix Testing for this PR has been completed but I didn't find anything to test!

@jsinglet
Copy link
Contributor

🤖 Beep Boop!qcc/c/AARCH64LE Matrix Testing for this PR has been completed. See below for the results!

SUITE                : MISRA-C-2012RULE                 : RULE-10-5TEST_DIFFERENCE      : PACKAGE              : EssentialTypesCOMPILE_ERROR_OUTPUT : QUERY                : InappropriateEssentialTypeCastCOMPILE_PASS         : TrueTEST_PASS            : True

@jsinglet
Copy link
Contributor

🤖 Beep Boop! Matrix Testing for this PR has beencompleted. If no reports were posted it means this PR does not contain things that need matrix testing!

@jsinglet
Copy link
Contributor

🤖 Beep Boop!qcc/c/AARCH64LE Matrix Testing for this PR has been completed. See below for the results!

TEST_PASS            : TrueRULE                 : RULE-10-5COMPILE_PASS         : TrueCOMPILE_ERROR_OUTPUT : TEST_DIFFERENCE      : SUITE                : MISRA-C-2012PACKAGE              : EssentialTypesQUERY                : InappropriateEssentialTypeCast

@jsinglet
Copy link
Contributor

🤖 Beep Boop! Matrix Testing for this PR has beencompleted. If no reports were posted it means this PR does not contain things that need matrix testing!

@jsinglet
Copy link
Contributor

/test-performance

@github-actions
Copy link

🏁 Beep Boop! Performance testing for this PR has been initiated. Please check back later for results. Note that the query package generation step must complete before testing will start so it might be a minute.

💡 If you do not hear back from me please check my status!I will report even if I fail!

@jsinglet
Copy link
Contributor

🏁 Beep Boop! Performance testing complete! See below for performance of the last 3 runs vs your PR. Times are based on predicate performance. You canfind full graphs and stats in the PR that was created for this test in the release engineering repo.

Release                            : v2.13.0Platform                           : x86-windowsLanguage                           : cTotal_Serialized_Execution_Time_Ms : 3268794Mean_Predicate_Execution_Time_Ms   : 141.10917332182171Median_Predicate_Execution_Time_Ms : 5.0Standard_Deviation_Ms              : 2347.189663268768Total_Serialized_Execution_Time_s  : 3268.794Mean_Query_Execution_Time_s        : 0.1411091733218217Median_Predicate_Execution_Time_s  : 0.005Percentile95_Ms                    : 300.0Number_of_Predicates               : 23165Release                            : v2.13.0Platform                           : x86-windowsLanguage                           : cppTotal_Serialized_Execution_Time_Ms : 4405198Mean_Predicate_Execution_Time_Ms   : 110.18504252126064Median_Predicate_Execution_Time_Ms : 3.0Standard_Deviation_Ms              : 1816.991907084716Total_Serialized_Execution_Time_s  : 4405.198Mean_Query_Execution_Time_s        : 0.1101850425212606Median_Predicate_Execution_Time_s  : 0.003Percentile95_Ms                    : 222.0Number_of_Predicates               : 39980Release                            : v2.13.0Platform                           : x86-linuxLanguage                           : cppTotal_Serialized_Execution_Time_Ms : 3877306Mean_Predicate_Execution_Time_Ms   : 97.3048410168896Median_Predicate_Execution_Time_Ms : 2.0Standard_Deviation_Ms              : 1572.1314154912643Total_Serialized_Execution_Time_s  : 3877.306Mean_Query_Execution_Time_s        : 0.0973048410168896Median_Predicate_Execution_Time_s  : 0.002Percentile95_Ms                    : 200.0Number_of_Predicates               : 39847Release                            : v2.13.0Platform                           : x86-linuxLanguage                           : cTotal_Serialized_Execution_Time_Ms : 2851919Mean_Predicate_Execution_Time_Ms   : 123.07077201916024Median_Predicate_Execution_Time_Ms : 3.0Standard_Deviation_Ms              : 1960.041520356055Total_Serialized_Execution_Time_s  : 2851.919Mean_Query_Execution_Time_s        : 0.1230707720191602Median_Predicate_Execution_Time_s  : 0.003Percentile95_Ms                    : 266.0Number_of_Predicates               : 23173Release                            : v2.14.0Platform                           : x86-windowsLanguage                           : cTotal_Serialized_Execution_Time_Ms : 3330223Mean_Predicate_Execution_Time_Ms   : 125.4557543793558Median_Predicate_Execution_Time_Ms : 4.0Standard_Deviation_Ms              : 2125.712933594389Total_Serialized_Execution_Time_s  : 3330.223Mean_Query_Execution_Time_s        : 0.1254557543793558Median_Predicate_Execution_Time_s  : 0.004Percentile95_Ms                    : 271.0Number_of_Predicates               : 26545Release                            : v2.14.0Platform                           : x86-linuxLanguage                           : cppTotal_Serialized_Execution_Time_Ms : 3910243Mean_Predicate_Execution_Time_Ms   : 97.5706906876934Median_Predicate_Execution_Time_Ms : 2.0Standard_Deviation_Ms              : 1583.9926359710646Total_Serialized_Execution_Time_s  : 3910.243Mean_Query_Execution_Time_s        : 0.0975706906876933Median_Predicate_Execution_Time_s  : 0.002Percentile95_Ms                    : 200.0Number_of_Predicates               : 40076Release                            : v2.14.0Platform                           : x86-linuxLanguage                           : cTotal_Serialized_Execution_Time_Ms : 2886922Mean_Predicate_Execution_Time_Ms   : 108.65344373353406Median_Predicate_Execution_Time_Ms : 2.0Standard_Deviation_Ms              : 1783.906509131339Total_Serialized_Execution_Time_s  : 2886.922Mean_Query_Execution_Time_s        : 0.108653443733534Median_Predicate_Execution_Time_s  : 0.002Percentile95_Ms                    : 237.0Number_of_Predicates               : 26570Release                            : v2.14.0Platform                           : x86-windowsLanguage                           : cppTotal_Serialized_Execution_Time_Ms : 4498723Mean_Predicate_Execution_Time_Ms   : 112.41186906546729Median_Predicate_Execution_Time_Ms : 3.0Standard_Deviation_Ms              : 1841.844021324711Total_Serialized_Execution_Time_s  : 4498.723Mean_Query_Execution_Time_s        : 0.1124118690654672Median_Predicate_Execution_Time_s  : 0.003Percentile95_Ms                    : 224.0Number_of_Predicates               : 40020Release                            : 257Platform                           : x86-linuxLanguage                           : cppTotal_Serialized_Execution_Time_Ms : 3765517Mean_Predicate_Execution_Time_Ms   : 93.04924878916675Median_Predicate_Execution_Time_Ms : 2.0Standard_Deviation_Ms              : 1420.5122446365283Total_Serialized_Execution_Time_s  : 3765.517Mean_Query_Execution_Time_s        : 0.0930492487891667Median_Predicate_Execution_Time_s  : 0.002Percentile95_Ms                    : 187.0Number_of_Predicates               : 40468Release                            : 257Platform                           : x86-linuxLanguage                           : cTotal_Serialized_Execution_Time_Ms : 3230351Mean_Predicate_Execution_Time_Ms   : 114.2758950049526Median_Predicate_Execution_Time_Ms : 2.0Standard_Deviation_Ms              : 1844.6463044861569Total_Serialized_Execution_Time_s  : 3230.351Mean_Query_Execution_Time_s        : 0.1142758950049526Median_Predicate_Execution_Time_s  : 0.002Percentile95_Ms                    : 223.64999999999785Number_of_Predicates               : 28268

🏁 Below are the slowest predicates for the last 2 releases vs this PR.

Release           : v2.14.0Run               : 2023-03-02_02-14-06Platform          : x86-windowsLanguage          : cppSuite             : autosar-defaultPredicate         : UnusedIncludeDirectives::getANonLocalDependency#574b69bc#ffExecution_Time_Ms : 35422Release           : v2.14.0Run               : 2023-03-02_02-14-06Platform          : x86-windowsLanguage          : cppSuite             : autosar-defaultPredicate         : SSAConstruction::PhiInsertion::definitionHasRedefinition#2b11997e#fffExecution_Time_Ms : 35551Release           : v2.14.0Run               : 2023-03-02_02-14-06Platform          : x86-linuxLanguage          : cSuite             : misra-defaultPredicate         : #select#cpe#134#fff#sharedExecution_Time_Ms : 136465Release           : v2.14.0Run               : 2023-03-02_02-14-06Platform          : x86-windowsLanguage          : cppSuite             : autosar-defaultPredicate         : NameInDependentBase::parentMemberFunctionCall#6fb39822#fffExecution_Time_Ms : 145768Release           : v2.14.0Run               : 2023-03-02_02-14-06Platform          : x86-windowsLanguage          : cppSuite             : autosar-defaultPredicate         : m##DataFlowUtil::localFlowStep#7572fbecPlus#bfExecution_Time_Ms : 173664Release           : v2.14.0Run               : 2023-03-02_02-14-06Platform          : x86-windowsLanguage          : cppSuite             : autosar-defaultPredicate         : Dependency::dependsOnTransitive#b0c9183e#ffExecution_Time_Ms : 231282Release           : v2.14.0Run               : 2023-03-02_02-14-06Platform          : x86-linuxLanguage          : cSuite             : misra-defaultPredicate         : #select#ff#antijoin_rhsExecution_Time_Ms : 198068Release           : v2.14.0Run               : 2023-03-02_02-14-06Platform          : x86-windowsLanguage          : cSuite             : misra-defaultPredicate         : #select#cpe#134#fff#antijoin_rhsExecution_Time_Ms : 64027Release           : v2.14.0Run               : 2023-03-02_02-14-06Platform          : x86-windowsLanguage          : cSuite             : misra-defaultPredicate         : #select#cpe#13456#fffff#sharedExecution_Time_Ms : 122933Release           : v2.14.0Run               : 2023-03-02_02-14-06Platform          : x86-windowsLanguage          : cSuite             : misra-defaultPredicate         : #select#cpe#134#fff#sharedExecution_Time_Ms : 171881Release           : v2.14.0Run               : 2023-03-02_02-14-06Platform          : x86-windowsLanguage          : cSuite             : misra-defaultPredicate         : #select#ff#antijoin_rhsExecution_Time_Ms : 227605Release           : v2.14.0Run               : 2023-03-02_02-14-06Platform          : x86-windowsLanguage          : cSuite             : misra-defaultPredicate         : SSAConstruction::DefUse::hasNonPhiDefinition#2b11997e#ffffExecution_Time_Ms : 34177Release           : v2.14.0Run               : 2023-03-02_02-14-06Platform          : x86-linuxLanguage          : cppSuite             : cert-defaultPredicate         : SSAConstruction::DefUse::hasNonPhiDefinition#2b11997e#ffffExecution_Time_Ms : 30531Release           : v2.14.0Run               : 2023-03-02_02-14-06Platform          : x86-linuxLanguage          : cppSuite             : autosar-defaultPredicate         : NameInDependentBase::parentMemberFunctionCall#6fb39822#fffExecution_Time_Ms : 130555Release           : v2.14.0Run               : 2023-03-02_02-14-06Platform          : x86-linuxLanguage          : cppSuite             : autosar-defaultPredicate         : m##DataFlowUtil::localFlowStep#7572fbecPlus#bfExecution_Time_Ms : 166984Release           : v2.14.0Run               : 2023-03-02_02-14-06Platform          : x86-linuxLanguage          : cppSuite             : autosar-defaultPredicate         : Dependency::dependsOnTransitive#b0c9183e#ffExecution_Time_Ms : 181966Release           : v2.14.0Run               : 2023-03-02_02-14-06Platform          : x86-linuxLanguage          : cSuite             : misra-defaultPredicate         : #select#cpe#1#f#antijoin_rhsExecution_Time_Ms : 28654Release           : v2.14.0Run               : 2023-03-02_02-14-06Platform          : x86-linuxLanguage          : cSuite             : misra-defaultPredicate         : #select#cpe#134#fff#antijoin_rhsExecution_Time_Ms : 58447Release           : v2.14.0Run               : 2023-03-02_02-14-06Platform          : x86-linuxLanguage          : cSuite             : misra-defaultPredicate         : #select#cpe#13456#fffff#sharedExecution_Time_Ms : 93370Release           : v2.14.0Run               : 2023-03-02_02-14-06Platform          : x86-linuxLanguage          : cppSuite             : autosar-defaultPredicate         : UnusedIncludeDirectives::getANonLocalDependency#574b69bc#ffExecution_Time_Ms : 30386Release           : 257Run               : 2023-03-16_18-50-03Platform          : x86-linuxLanguage          : cSuite             : misra-defaultPredicate         : #select#cpe#134#fff#sharedExecution_Time_Ms : 136037Release           : 257Run               : 2023-03-16_18-50-03Platform          : x86-linuxLanguage          : cSuite             : misra-defaultPredicate         : #select#cpe#134#fff#antijoin_rhsExecution_Time_Ms : 67190Release           : 257Run               : 2023-03-16_18-50-03Platform          : x86-linuxLanguage          : cSuite             : misra-defaultPredicate         : RepeatedInitializationOfAggregateObjectElement#76b22bdc::hasMultipleInitializerExprsForSameField#2#ffExecution_Time_Ms : 66554Release           : 257Run               : 2023-03-16_18-50-03Platform          : x86-linuxLanguage          : cSuite             : misra-defaultPredicate         : RepeatedInitializationOfAggregateObjectElement#76b22bdc::hasMultipleInitializerExprsForSameIndexInternal#4#ffff#join_rhsExecution_Time_Ms : 57732Release           : 257Run               : 2023-03-16_18-50-03Platform          : x86-linuxLanguage          : cppSuite             : autosar-defaultPredicate         : UnusedIncludeDirectives#574b69bc::getANonLocalDependency#1#ffExecution_Time_Ms : 30611Release           : 257Run               : 2023-03-16_18-50-03Platform          : x86-linuxLanguage          : cppSuite             : autosar-defaultPredicate         : Dependency#b0c9183e::dependsOnTransitive#2#ffExecution_Time_Ms : 171937Release           : 257Run               : 2023-03-16_18-50-03Platform          : x86-linuxLanguage          : cppSuite             : autosar-defaultPredicate         : PreProcessorShallOnlyBeUsedForCertainDirectivesPatterns#32e68f1c::getAGuard#1#ffExecution_Time_Ms : 31210Release           : 257Run               : 2023-03-16_18-50-03Platform          : x86-linuxLanguage          : cppSuite             : autosar-defaultPredicate         : SSAConstruction#2b11997e::PhiInsertion::definitionHasRedefinition#3#fffExecution_Time_Ms : 28610Release           : 257Run               : 2023-03-16_18-50-03Platform          : x86-linuxLanguage          : cppSuite             : autosar-defaultPredicate         : m##DataFlowUtil#7572fbec::localFlowStep#2Plus#bfExecution_Time_Ms : 176585Release           : 257Run               : 2023-03-16_18-50-03Platform          : x86-linuxLanguage          : cSuite             : misra-defaultPredicate         : #select#ff#antijoin_rhsExecution_Time_Ms : 213643

The calculatons for signed and unsigned type of lowest rank wereexpensive when there were a large number of constant expressions in theprogram. This commit improves performance by: 1. Creating classes to represent the set of integer constantexpressions and integer constants in the program. 2. Creating a candidate table of IntegralTypes for each known constantinteger value in the program, to avoid duplicate work. 3. Calculating the stlr and utlr for each constant value, not eachconstant expression.
This improves the performance of Rule 10.5 by computing all the types ofthe cast first, before determining whether they were invalid. Previouslythe join orderer found the essential type category of the "from" type,then joined that will invalid type categories, then joined that with allexpressions of that type before filtering down to the cast.
@lcarteylcarteyforce-pushed thelcartey/improve-essential-type-performance branch fromd4fe61f tobc4db01CompareMarch 17, 2023 13:12
@github-actions
Copy link

🤖 Beep Boop! Matrix Testing for this PR has been initiated. Please check back later for results.

💡 If you do not hear back from me please check my status!I will report even if this PR does not contain files eligible for matrix testing.

@lcartey
Copy link
ContributorAuthor

Performance test doesn't compare a version that included the "slow" essential types library, but we can see vs. 2.14.0 that:

  • It actually completes (whereas 2.15.0 failed the performance test completely).
  • The overall time does increase, but inspecting the list of slowest predicates, I think that's related to "RepeatedInitializationOfAggregateObjectElement" which was recently added.
  • NoEssentialTypes predicates appear in the list of slowest predicates.

Added a change note and rebased, so I think this is ready to go.

jsinglet reacted with heart emoji

@jsinglet
Copy link
Contributor

🤖 Beep Boop!gcc/c/X86_64 Matrix Testing for this PR has been completed. See below for the results!

COMPILE_PASS         : TrueTEST_DIFFERENCE      : RULE                 : RULE-10-5SUITE                : MISRA-C-2012TEST_PASS            : TruePACKAGE              : EssentialTypesCOMPILE_ERROR_OUTPUT : QUERY                : InappropriateEssentialTypeCast

@jsinglet
Copy link
Contributor

🤖 Beep Boop!clang/c/X86_64 Matrix Testing for this PR has been completed. See below for the results!

TEST_DIFFERENCE      : SUITE                : MISRA-C-2012COMPILE_PASS         : TruePACKAGE              : EssentialTypesTEST_PASS            : TrueQUERY                : InappropriateEssentialTypeCastCOMPILE_ERROR_OUTPUT : RULE                 : RULE-10-5

@jsinglet
Copy link
Contributor

🤖 Beep Boop!qcc/cpp/AARCH64LE Matrix Testing for this PR won't happen because it is outside of license window!

@jsinglet
Copy link
Contributor

🤖 Beep Boop!clang/cpp/X86_64 Matrix Testing for this PR has been completed but I didn't find anything to test!

@jsinglet
Copy link
Contributor

🤖 Beep Boop!gcc/cpp/X86_64 Matrix Testing for this PR has been completed but I didn't find anything to test!

@jsinglet
Copy link
Contributor

🤖 Beep Boop!qcc/c/AARCH64LE Matrix Testing for this PR won't happen because it is outside of license window!

@jsinglet
Copy link
Contributor

🤖 Beep Boop! Matrix Testing for this PR has beencompleted. If no reports were posted it means this PR does not contain things that need matrix testing!

@jsingletjsinglet changed the base branch frommain torc/2.15March 17, 2023 13:18
@jsingletjsinglet changed the base branch fromrc/2.15 tomainMarch 17, 2023 13:20
Copy link
Contributor

@jsingletjsinglet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks@lcartey!!!

@jsingletjsinglet added this pull request to themerge queueMar 17, 2023
Merged via the queue intomain with commit4a04ff2Mar 17, 2023
@jsingletjsinglet deleted the lcartey/improve-essential-type-performance branchMarch 17, 2023 14:59
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

@jsingletjsingletjsinglet approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lcartey@jsinglet
[8]ページ先頭
©2009-2025 Movatter.jp