Jan 18, 2023 · Jan 5, 2023 · Jan 9, 2023 · Jan 9, 2023 · Jan 9, 2023 · Jan 9, 2023
diff --git a/.vscode/tasks.json b/.vscode/tasks.json
                "Declarations3",
                "Declarations4",
                "Declarations5",
                "Declarations6",
                "Exceptions1",
                "Exceptions2",
                "Expressions",
diff --git a/c/cert/src/rules/DCL38-C/DeclaringAFlexibleArrayMember.ql b/c/cert/src/rules/DCL38-C/DeclaringAFlexibleArrayMember.ql

 import cpp
 import codingstandards.c.cert

 /**
 * A member with the type array that is last in a struct
 * includes any sized array (either specified or not)
 */
 class FlexibleArrayMember extends MemberVariable {
  Struct s;

  FlexibleArrayMember() {
    this.getType() instanceof ArrayType and
    this.getDeclaringType() = s and
    not exists(int i, int j |
      s.getAMember(i) = this and
      exists(s.getAMember(j)) and
      j > i
    )
  }
 }
 import codingstandards.c.Variable

 from VariableDeclarationEntry m, ArrayType a
 where
  not isExcluded(m, Declarations2Package::declaringAFlexibleArrayMemberQuery()) and
  m.getType() = a and
  m.getVariable() instanceofFlexibleArrayMember and
  m.getVariable() instanceofFlexibleArrayMemberCandidate and
  a.getArraySize() = 1
 select m, "Incorrect syntax used for declaring this flexible array member."
diff --git a/c/common/src/codingstandards/c/Variable.qll b/c/common/src/codingstandards/c/Variable.qll
  /* Extractor workaround do determine if a VLA array has the specifier volatile.*/
  override predicate isVolatile() { this.getType().(ArrayType).getBaseType().isVolatile() }
 }

 /**
 * A flexible array member
 * ie member with the type array that is last in a struct
 * has no size specified
 */
 class FlexibleArrayMember extends FlexibleArrayMemberCandidate {
  FlexibleArrayMember() {
    exists(ArrayType t |
      this.getType() = t and
      not exists(t.getSize())
    )
  }
 }

 /**
 * A member with the type array that is last in a struct
 * includes any sized array (either specified or not)
 */
 class FlexibleArrayMemberCandidate extends MemberVariable {
  Struct s;

  FlexibleArrayMemberCandidate() {
    this.getType() instanceof ArrayType and
    this.getDeclaringType() = s and
    not exists(int i, int j |
      s.getAMember(i) = this and
      exists(s.getAMember(j)) and
      j > i
    )
  }
 }
diff --git a/c/misra/src/rules/RULE-17-3/FunctionDeclaredImplicitly.ql b/c/misra/src/rules/RULE-17-3/FunctionDeclaredImplicitly.ql
 /**
 * @id c/misra/function-declared-implicitly
 * @name RULE-17-3: A function shall not be declared implicitly
 * @description Omission of type specifiers may not be supported by some compilers. Additionally
 *              implicit typing can lead to undefined behaviour.
 * @kind problem
 * @precision very-high
 * @problem.severity error
 * @tags external/misra/id/rule-17-3
 *       correctness
 *       readability
 *       external/misra/obligation/mandatory
 */

 import cpp
 import codingstandards.c.misra
 import codingstandards.cpp.Identifiers

 from FunctionDeclarationEntry fde
 where
  not isExcluded(fde, Declarations6Package::functionDeclaredImplicitlyQuery()) and
  (
    //use before declaration
    fde.isImplicit()
    or
    //declared but type not explicit
    isDeclaredImplicit(fde.getDeclaration())
  )
 select fde, "Function declaration is implicit."
diff --git a/c/misra/src/rules/RULE-18-7/FlexibleArrayMembersDeclared.ql b/c/misra/src/rules/RULE-18-7/FlexibleArrayMembersDeclared.ql
 /**
 * @id c/misra/flexible-array-members-declared
 * @name RULE-18-7: Flexible array members shall not be declared
 * @description The use of flexible array members can lead to unexpected program behaviour.
 * @kind problem
 * @precision very-high
 * @problem.severity error
 * @tags external/misra/id/rule-18-7
 *       correctness
 *       external/misra/obligation/required
 */

 import cpp
 import codingstandards.c.misra
 import codingstandards.c.Variable

 from FlexibleArrayMember f
 where not isExcluded(f, Declarations6Package::flexibleArrayMembersDeclaredQuery())
 select f, "Flexible array member declared."
diff --git a/c/misra/src/rules/RULE-5-8/IdentifiersWithExternalLinkageNotUnique.ql b/c/misra/src/rules/RULE-5-8/IdentifiersWithExternalLinkageNotUnique.ql
 /**
 * @id c/misra/identifiers-with-external-linkage-not-unique
 * @name RULE-5-8: Identifiers that define objects or functions with external linkage shall be unique
 * @description Using non-unique identifiers can lead to developer confusion.
 * @kind problem
 * @precision very-high
 * @problem.severity error
 * @tags external/misra/id/rule-5-8
 *       maintainability
 *       readability
 *       external/misra/obligation/required
 */

 import cpp
 import codingstandards.c.misra
 import codingstandards.cpp.Identifiers

 from Declaration de, ExternalIdentifiers e
 where
  not isExcluded(de, Declarations6Package::identifiersWithExternalLinkageNotUniqueQuery()) and
  not isExcluded(e, Declarations6Package::identifiersWithExternalLinkageNotUniqueQuery()) and
  not de = e and
  de.getName() = e.getName()
 select de, "Identifier conflicts with external identifier $@", e, e.getName()
diff --git a/c/misra/src/rules/RULE-5-9/IdentifiersWithInternalLinkageNotUnique.ql b/c/misra/src/rules/RULE-5-9/IdentifiersWithInternalLinkageNotUnique.ql
 /**
 * @id c/misra/identifiers-with-internal-linkage-not-unique
 * @name RULE-5-9: Identifiers that define objects or functions with internal linkage should be unique
 * @description Using non-unique identifiers can lead to developer confusion.
 * @kind problem
 * @precision very-high
 * @problem.severity error
 * @tags external/misra/id/rule-5-9
 *       maintainability
 *       readability
 *       external/misra/obligation/advisory
 */

 import cpp
 import codingstandards.c.misra

 from Declaration d1, Declaration d2
 where
  not isExcluded(d1, Declarations6Package::identifiersWithInternalLinkageNotUniqueQuery()) and
  not isExcluded(d2, Declarations6Package::identifiersWithInternalLinkageNotUniqueQuery()) and
  d1.isStatic() and
  d1.isTopLevel() and
  not d1 = d2 and
  d1.getName() = d2.getName() and
  // Apply an ordering based on location to enforce that (d1, d2) = (d2, d1) and we only report (d1, d2).
  (
    d1.getFile().getAbsolutePath() < d2.getFile().getAbsolutePath()
    or
    d1.getFile().getAbsolutePath() = d2.getFile().getAbsolutePath() and
    d1.getLocation().getStartLine() < d2.getLocation().getStartLine()
  )
 select d2, "Identifier conflicts with identifier $@ with internal linkage.", d1, d1.getName()
diff --git a/c/misra/src/rules/RULE-8-10/InlineFunctionNotDeclaredStaticStorage.ql b/c/misra/src/rules/RULE-8-10/InlineFunctionNotDeclaredStaticStorage.ql
 /**
 * @id c/misra/inline-function-not-declared-static-storage
 * @name RULE-8-10: An inline function shall be declared with the static storage class
 * @description Declaring an inline function with external linkage can lead to undefined or
 *              incorrect program behaviour.
 * @kind problem
 * @precision very-high
 * @problem.severity error
 * @tags external/misra/id/rule-8-10
 *       correctness
 *       external/misra/obligation/required
 */

 import cpp
 import codingstandards.c.misra
 import codingstandards.cpp.Identifiers

 from FunctionDeclarationEntry f
 where
  not isExcluded(f, Declarations6Package::inlineFunctionNotDeclaredStaticStorageQuery()) and
  f.getFunction() instanceof InterestingIdentifiers and
  f.getFunction().isInline() and
  not f.hasSpecifier("static")
 select f, "Inline function not explicitly declared static."
diff --git a/c/misra/src/rules/RULE-8-11/ArrayExternalLinkageSizeExplicitlySpecified.ql b/c/misra/src/rules/RULE-8-11/ArrayExternalLinkageSizeExplicitlySpecified.ql
 /**
 * @id c/misra/array-external-linkage-size-explicitly-specified
 * @name RULE-8-11: When an array with external linkage is declared, its size should be explicitly specified
 * @description Declaring an array without an explicit size disallows the compiler and static
 *              checkers from doing array bounds analysis and can lead to less readable, unsafe
 *              code.
 * @kind problem
 * @precision very-high
 * @problem.severity error
 * @tags external/misra/id/rule-8-11
 *       correctness
 *       readability
 *       external/misra/obligation/advisory
 */

 import cpp
 import codingstandards.c.misra
 import codingstandards.cpp.Identifiers

 from VariableDeclarationEntry v, ArrayType t
 where
  not isExcluded(v, Declarations6Package::arrayExternalLinkageSizeExplicitlySpecifiedQuery()) and
  v.getDeclaration() instanceof ExternalIdentifiers and
  v.getType() = t and
  not exists(t.getSize()) and
  //this rule applies to non-defining declarations only
  not v.isDefinition()
 select v, "Array declared without explicit size."
diff --git a/c/misra/src/rules/RULE-8-7/ShouldNotBeDefinedWithExternalLinkage.ql b/c/misra/src/rules/RULE-8-7/ShouldNotBeDefinedWithExternalLinkage.ql
 /**
 * @id c/misra/should-not-be-defined-with-external-linkage
 * @name RULE-8-7: Functions and objects should not be defined with external linkage if they are referenced in only one
 * @description Declarations with external linkage that are referenced in only one translation unit
 *              can indicate an intention to only have those identifiers accessible in that
 *              translation unit and accidental future accesses in other translation units can lead
 *              to confusing program behaviour.
 * @kind problem
 * @precision very-high
 * @problem.severity error
 * @tags external/misra/id/rule-8-7
 *       correctness
 *       maintainability
 *       readability
 *       external/misra/obligation/advisory
 */

 import cpp
 import codingstandards.c.misra
 import codingstandards.cpp.Identifiers
 import codingstandards.cpp.Scope

 /**
 * Re-introduce function calls into access description as
 * "any reference"
 */
 classReferenceextendsNameQualifiableElement{
 Reference(){
 thisinstanceofAccessor
 thisinstanceofFunctionCall
 }
 }

 fromExternalIdentifierse,Referencea1,TranslationUnitt1
 where
 notisExcluded(e, Declarations6Package::shouldNotBeDefinedWithExternalLinkageQuery())and
 (a1.(Access).getTarget()=eora1.(FunctionCall).getTarget()=e)and
 a1.getFile()=t1and
 //not accessed in any other translation unit
 notexists(TranslationUnitt2,Referencea2|
 nott1=t2and
 (a2.(Access).getTarget()=eora2.(FunctionCall).getTarget()=e)and
 a2.getFile()=t2
 )
 selecte,"Declaration with external linkage is accessed in only one translation unit $@.",a1,
 a1.toString()
diff --git a/c/misra/test/rules/RULE-17-3/FunctionDeclaredImplicitly.expected b/c/misra/test/rules/RULE-17-3/FunctionDeclaredImplicitly.expected
 | test.c:4:1:4:2 | declaration of f2 | Function declaration is implicit. |
 | test.c:12:15:12:15 | declaration of f3 | Function declaration is implicit. |
diff --git a/c/misra/test/rules/RULE-17-3/FunctionDeclaredImplicitly.qlref b/c/misra/test/rules/RULE-17-3/FunctionDeclaredImplicitly.qlref
 rules/RULE-17-3/FunctionDeclaredImplicitly.ql
diff --git a/c/misra/test/rules/RULE-17-3/test.c b/c/misra/test/rules/RULE-17-3/test.c
 // semmle-extractor-options:--clang -std=c11 -nostdinc
 // -I../../../../common/test/includes/standard-library
 double f1(double x); // COMPLIANT
 f2(double x);        // NON_COMPLIANT

 void f() {
  double l = 1;
  double l1 = f1(l);

  double l2 = f2(l);

  double l3 = f3(l); // NON_COMPLIANT
 }
diff --git a/c/misra/test/rules/RULE-18-7/FlexibleArrayMembersDeclared.expected b/c/misra/test/rules/RULE-18-7/FlexibleArrayMembersDeclared.expected
 | test.c:8:7:8:7 | b | Flexible array member declared. |
diff --git a/c/misra/test/rules/RULE-18-7/FlexibleArrayMembersDeclared.qlref b/c/misra/test/rules/RULE-18-7/FlexibleArrayMembersDeclared.qlref
 rules/RULE-18-7/FlexibleArrayMembersDeclared.ql
diff --git a/c/misra/test/rules/RULE-18-7/test.c b/c/misra/test/rules/RULE-18-7/test.c
 struct s {
  int a;
  int b[1]; // COMPLIANT
 };

 struct s1 {
  int a;
  int b[]; // NON_COMPLIANT
 };

 struct s2 {
  int a;
  int b[2]; // COMPLIANT
 };

 struct s3 {
  int a;
  int b[1]; // COMPLIANT
  int a1;
 };
diff --git a/c/misra/test/rules/RULE-5-8/IdentifiersWithExternalLinkageNotUnique.expected b/c/misra/test/rules/RULE-5-8/IdentifiersWithExternalLinkageNotUnique.expected
 | test1.c:1:13:1:13 | f | Identifier conflicts with external identifier $@ | test.c:3:6:3:6 | f | f |
 | test1.c:2:7:2:7 | g | Identifier conflicts with external identifier $@ | test.c:1:5:1:5 | g | g |
diff --git a/c/misra/test/rules/RULE-5-8/IdentifiersWithExternalLinkageNotUnique.qlref b/c/misra/test/rules/RULE-5-8/IdentifiersWithExternalLinkageNotUnique.qlref
 rules/RULE-5-8/IdentifiersWithExternalLinkageNotUnique.ql
diff --git a/c/misra/test/rules/RULE-5-8/test.c b/c/misra/test/rules/RULE-5-8/test.c
 int g;
 extern int g1; // COMPLIANT
 void f() { int i; }
diff --git a/c/misra/test/rules/RULE-5-8/test1.c b/c/misra/test/rules/RULE-5-8/test1.c
 static void f() { // NON_COMPLIANT
  int g;          // NON_COMPLIANT
  int i;          // COMPLIANT
 }
 int g1; // COMPLIANT
diff --git a/c/misra/test/rules/RULE-5-9/IdentifiersWithInternalLinkageNotUnique.expected b/c/misra/test/rules/RULE-5-9/IdentifiersWithInternalLinkageNotUnique.expected
 | test1.c:2:12:2:13 | g1 | Identifier conflicts with identifier $@ with internal linkage. | test.c:1:12:1:13 | g1 | g1 |
 | test1.c:4:13:4:13 | f | Identifier conflicts with identifier $@ with internal linkage. | test.c:2:13:2:13 | f | f |
 | test1.c:5:7:5:7 | g | Identifier conflicts with identifier $@ with internal linkage. | test1.c:1:12:1:12 | g | g |
 | test1.c:10:7:10:7 | g | Identifier conflicts with identifier $@ with internal linkage. | test1.c:1:12:1:12 | g | g |
diff --git a/c/misra/test/rules/RULE-5-9/IdentifiersWithInternalLinkageNotUnique.qlref b/c/misra/test/rules/RULE-5-9/IdentifiersWithInternalLinkageNotUnique.qlref
 rules/RULE-5-9/IdentifiersWithInternalLinkageNotUnique.ql
diff --git a/c/misra/test/rules/RULE-5-9/test.c b/c/misra/test/rules/RULE-5-9/test.c
 staticintg1;// NON_COMPLIANT
 staticvoidf();// NON_COMPLIANT
diff --git a/c/misra/test/rules/RULE-5-9/test1.c b/c/misra/test/rules/RULE-5-9/test1.c
 static int g;  // COMPLIANT
 static int g1; // NON_COMPLIANT

 static void f() { // NON_COMPLIANT
  int g;          // NON_COMPLIANT
  int g2;         // COMPLIANT
 }

 void f1() { // COMPLIANT
  int g;    // NON_COMPLIANT
  int g2;   // COMPLIANT
 }
diff --git a/c/misra/test/rules/RULE-8-10/InlineFunctionNotDeclaredStaticStorage.expected b/c/misra/test/rules/RULE-8-10/InlineFunctionNotDeclaredStaticStorage.expected
 | test.c:2:20:2:21 | declaration of f1 | Inline function not explicitly declared static. |
 | test.c:3:13:3:14 | declaration of f2 | Inline function not explicitly declared static. |
 | test.c:4:20:4:20 | declaration of f | Inline function not explicitly declared static. |
diff --git a/c/misra/test/rules/RULE-8-10/InlineFunctionNotDeclaredStaticStorage.qlref b/c/misra/test/rules/RULE-8-10/InlineFunctionNotDeclaredStaticStorage.qlref
 rules/RULE-8-10/InlineFunctionNotDeclaredStaticStorage.ql
diff --git a/c/misra/test/rules/RULE-8-10/test.c b/c/misra/test/rules/RULE-8-10/test.c
 static inline void f();  // COMPLIANT
 extern inline void f1(); // NON_COMPLIANT
 inline void f2();        // NON_COMPLIANT
 extern inline void f(); // NON_COMPLIANT -while this will be internal linkage it
                        // is less clear than explicitly specifying static
diff --git a/c/misra/test/rules/RULE-8-11/ArrayExternalLinkageSizeExplicitlySpecified.expected b/c/misra/test/rules/RULE-8-11/ArrayExternalLinkageSizeExplicitlySpecified.expected
 | test.c:2:12:2:13 | declaration of a1 | Array declared without explicit size. |
diff --git a/c/misra/test/rules/RULE-8-11/ArrayExternalLinkageSizeExplicitlySpecified.qlref b/c/misra/test/rules/RULE-8-11/ArrayExternalLinkageSizeExplicitlySpecified.qlref
 rules/RULE-8-11/ArrayExternalLinkageSizeExplicitlySpecified.ql
Original file line number	Diff line number	Diff line change
Expand Up		@@ -209,6 +209,7 @@
		"Declarations3",
		"Declarations4",
		"Declarations5",
		"Declarations6",
		"Exceptions1",
		"Exceptions2",
		"Expressions",
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -15,29 +15,12 @@

		import cpp
		import codingstandards.c.cert

		/**
		* A member with the type array that is last in a struct
		* includes any sized array (either specified or not)
		*/
		class FlexibleArrayMember extends MemberVariable {
		Struct s;

		FlexibleArrayMember() {
		this.getType() instanceof ArrayType and
		this.getDeclaringType() = s and
		not exists(int i, int j \|
		s.getAMember(i) = this and
		exists(s.getAMember(j)) and
		j > i
		)
		}
		}
		import codingstandards.c.Variable

		from VariableDeclarationEntry m, ArrayType a
		where
		not isExcluded(m, Declarations2Package::declaringAFlexibleArrayMemberQuery()) and
		m.getType() = a and
		m.getVariable() instanceofFlexibleArrayMember and
		m.getVariable() instanceofFlexibleArrayMemberCandidate and
		a.getArraySize() = 1
		select m, "Incorrect syntax used for declaring this flexible array member."
Original file line number	Diff line number	Diff line change
Expand Up		@@ -6,3 +6,35 @@ class VlaVariable extends Variable {
		/* Extractor workaround do determine if a VLA array has the specifier volatile.*/
		override predicate isVolatile() { this.getType().(ArrayType).getBaseType().isVolatile() }
		}

		/**
		* A flexible array member
		* ie member with the type array that is last in a struct
		* has no size specified
		*/
		class FlexibleArrayMember extends FlexibleArrayMemberCandidate {
		FlexibleArrayMember() {
		exists(ArrayType t \|
		this.getType() = t and
		not exists(t.getSize())
		)
		}
		}

		/**
		* A member with the type array that is last in a struct
		* includes any sized array (either specified or not)
		*/
		class FlexibleArrayMemberCandidate extends MemberVariable {
		Struct s;

		FlexibleArrayMemberCandidate() {
		this.getType() instanceof ArrayType and
		this.getDeclaringType() = s and
		not exists(int i, int j \|
		s.getAMember(i) = this and
		exists(s.getAMember(j)) and
		j > i
		)
		}
		}
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,29 @@
		/**
		* @id c/misra/function-declared-implicitly
		* @name RULE-17-3: A function shall not be declared implicitly
		* @description Omission of type specifiers may not be supported by some compilers. Additionally
		* implicit typing can lead to undefined behaviour.
		* @kind problem
		* @precision very-high
		* @problem.severity error
		* @tags external/misra/id/rule-17-3
		* correctness
		* readability
		* external/misra/obligation/mandatory
		*/

		import cpp
		import codingstandards.c.misra
		import codingstandards.cpp.Identifiers

		from FunctionDeclarationEntry fde
		where
		not isExcluded(fde, Declarations6Package::functionDeclaredImplicitlyQuery()) and
		(
		//use before declaration
		fde.isImplicit()
		or
		//declared but type not explicit
		isDeclaredImplicit(fde.getDeclaration())
		)
		select fde, "Function declaration is implicit."
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,19 @@
		/**
		* @id c/misra/flexible-array-members-declared
		* @name RULE-18-7: Flexible array members shall not be declared
		* @description The use of flexible array members can lead to unexpected program behaviour.
		* @kind problem
		* @precision very-high
		* @problem.severity error
		* @tags external/misra/id/rule-18-7
		* correctness
		* external/misra/obligation/required
		*/

		import cpp
		import codingstandards.c.misra
		import codingstandards.c.Variable

		from FlexibleArrayMember f
		where not isExcluded(f, Declarations6Package::flexibleArrayMembersDeclaredQuery())
		select f, "Flexible array member declared."
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,24 @@
		/**
		* @id c/misra/identifiers-with-external-linkage-not-unique
		* @name RULE-5-8: Identifiers that define objects or functions with external linkage shall be unique
		* @description Using non-unique identifiers can lead to developer confusion.
		* @kind problem
		* @precision very-high
		* @problem.severity error
		* @tags external/misra/id/rule-5-8
		* maintainability
		* readability
		* external/misra/obligation/required
		*/

		import cpp
		import codingstandards.c.misra
		import codingstandards.cpp.Identifiers

		from Declaration de, ExternalIdentifiers e
		where
		not isExcluded(de, Declarations6Package::identifiersWithExternalLinkageNotUniqueQuery()) and
		not isExcluded(e, Declarations6Package::identifiersWithExternalLinkageNotUniqueQuery()) and
		not de = e and
		de.getName() = e.getName()
		select de, "Identifier conflicts with external identifier $@", e, e.getName()
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,32 @@
		/**
		* @id c/misra/identifiers-with-internal-linkage-not-unique
		* @name RULE-5-9: Identifiers that define objects or functions with internal linkage should be unique
		* @description Using non-unique identifiers can lead to developer confusion.
		* @kind problem
		* @precision very-high
		* @problem.severity error
		* @tags external/misra/id/rule-5-9
		* maintainability
		* readability
		* external/misra/obligation/advisory
		*/

		import cpp
		import codingstandards.c.misra

		from Declaration d1, Declaration d2
		where
		not isExcluded(d1, Declarations6Package::identifiersWithInternalLinkageNotUniqueQuery()) and
		not isExcluded(d2, Declarations6Package::identifiersWithInternalLinkageNotUniqueQuery()) and
		d1.isStatic() and
		d1.isTopLevel() and
		not d1 = d2 and
		d1.getName() = d2.getName() and
		// Apply an ordering based on location to enforce that (d1, d2) = (d2, d1) and we only report (d1, d2).
		(
		d1.getFile().getAbsolutePath() < d2.getFile().getAbsolutePath()
		or
		d1.getFile().getAbsolutePath() = d2.getFile().getAbsolutePath() and
		d1.getLocation().getStartLine() < d2.getLocation().getStartLine()
nicolaswill marked this conversation as resolved. Show resolvedHide resolved
		)
		select d2, "Identifier conflicts with identifier $@ with internal linkage.", d1, d1.getName()
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,24 @@
		/**
		* @id c/misra/inline-function-not-declared-static-storage
		* @name RULE-8-10: An inline function shall be declared with the static storage class
		* @description Declaring an inline function with external linkage can lead to undefined or
		* incorrect program behaviour.
		* @kind problem
		* @precision very-high
		* @problem.severity error
		* @tags external/misra/id/rule-8-10
		* correctness
		* external/misra/obligation/required
		*/

		import cpp
		import codingstandards.c.misra
		import codingstandards.cpp.Identifiers

		from FunctionDeclarationEntry f
		where
		not isExcluded(f, Declarations6Package::inlineFunctionNotDeclaredStaticStorageQuery()) and
		f.getFunction() instanceof InterestingIdentifiers and
		f.getFunction().isInline() and
		not f.hasSpecifier("static")
		select f, "Inline function not explicitly declared static."
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,28 @@
		/**
		* @id c/misra/array-external-linkage-size-explicitly-specified
		* @name RULE-8-11: When an array with external linkage is declared, its size should be explicitly specified
		* @description Declaring an array without an explicit size disallows the compiler and static
		* checkers from doing array bounds analysis and can lead to less readable, unsafe
		* code.
		* @kind problem
		* @precision very-high
		* @problem.severity error
		* @tags external/misra/id/rule-8-11
		* correctness
		* readability
		* external/misra/obligation/advisory
		*/

		import cpp
		import codingstandards.c.misra
		import codingstandards.cpp.Identifiers

		from VariableDeclarationEntry v, ArrayType t
		where
		not isExcluded(v, Declarations6Package::arrayExternalLinkageSizeExplicitlySpecifiedQuery()) and
		v.getDeclaration() instanceof ExternalIdentifiers and
		v.getType() = t and
		not exists(t.getSize()) and
		//this rule applies to non-defining declarations only
		not v.isDefinition()
		select v, "Array declared without explicit size."
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,46 @@
		/**
		* @id c/misra/should-not-be-defined-with-external-linkage
		* @name RULE-8-7: Functions and objects should not be defined with external linkage if they are referenced in only one
		* @description Declarations with external linkage that are referenced in only one translation unit
		* can indicate an intention to only have those identifiers accessible in that
		* translation unit and accidental future accesses in other translation units can lead
		* to confusing program behaviour.
		* @kind problem
		* @precision very-high
		* @problem.severity error
		* @tags external/misra/id/rule-8-7
		* correctness
		* maintainability
		* readability
		* external/misra/obligation/advisory
		*/

		import cpp
		import codingstandards.c.misra
		import codingstandards.cpp.Identifiers
		import codingstandards.cpp.Scope

		/**
		* Re-introduce function calls into access description as
		* "any reference"
		*/
		classReferenceextendsNameQualifiableElement{
		Reference(){
		thisinstanceofAccessor
		thisinstanceofFunctionCall
		}
		}

		fromExternalIdentifierse,Referencea1,TranslationUnitt1
		where
		notisExcluded(e, Declarations6Package::shouldNotBeDefinedWithExternalLinkageQuery())and
		(a1.(Access).getTarget()=eora1.(FunctionCall).getTarget()=e)and
		a1.getFile()=t1and
		//not accessed in any other translation unit
		notexists(TranslationUnitt2,Referencea2\|
		nott1=t2and
		(a2.(Access).getTarget()=eora2.(FunctionCall).getTarget()=e)and
		a2.getFile()=t2
		)
		selecte,"Declaration with external linkage is accessed in only one translation unit $@.",a1,
		a1.toString()