Commitdb71d1b

authored

Merge pull request#827 from rak3-sh/rp/fix-540

Fix#540: A3-9-1: Dont consider variables from template instantiations

2 parents89bd9b4 +23ddafa commitdb71d1bCopy full SHA for db71d1b

File tree

+18

-1

lines changed

+18

-1

lines changed

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	+-`A3-9-1` -`VariableWidthIntegerTypesUsed.ql`:
	`2`	`+- Reduce false positives by not considering variables from template instantiations.`

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -32,6 +32,10 @@ where`
`32`	`32`	`typeStrippedOfSpecifiersinstanceofSignedCharType`
`33`	`33`	`)and`
`34`	`34`	`notvinstanceofExcludedVariableand`
	`35`	`+// Dont consider template instantiations because instantiations with`
	`36`	`+// Fixed Width Types are recorded after stripping their typedef'd type,`
	`37`	`+// thereby, causing false positives (#540).`
	`38`	`+notv.isFromTemplateInstantiation(_)and`
`35`	`39`	`//post-increment/post-decrement operators are required by the standard to have a dummy int parameter`
`36`	`40`	`notv.(Parameter).getFunction()instanceofPostIncrementOperatorand`
`37`	`41`	`notv.(Parameter).getFunction()instanceofPostDecrementOperator`

Lines changed: 12 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -75,4 +75,15 @@ void test_variable_width_type_qualified_variables() {`
`75`	`75`	`structtest_fix_fp_614 {`
`76`	`76`	`test_fix_fp_614operator++(int);// COMPLIANT`
`77`	`77`	`test_fix_fp_614operator--(int);// COMPLIANT`
`78`		`-};`
	`78`	`+};`
	`79`	`+`
	`80`	`+// COMPLIANT - instantiated with Fixed Width Types.`
	`81`	`+template<typename MyType>constexprvoidtest_fix_fp_540(MyType value) {`
	`82`	`+ value++;`
	`83`	`+}`
	`84`	`+`
	`85`	`+intcall_test_fix_fp_540() {`
	`86`	`+ test_fix_fp_540<std::uint8_t>(19);`
	`87`	`+ test_fix_fp_540<std::int16_t>(20);`
	`88`	`+return0;`
	`89`	`+}`

Comments

(0)