Commit5e17d21

authored

Merge pull request#414 from github/lcartey/a0-1-1-ignore-incomplete-or-compiler-generated-vars

`A0-1-1`: Ignore incomplete or compiler generated variables

2 parentsbf45f8c +8043222 commit5e17d21Copy full SHA for 5e17d21

File tree

+22

-3

lines changed

+22

-3

lines changed

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,4 @@`
	`1`	+*`A0-1-1` - address a number of false positive issues:
	`2`	`+* Exclude compiler-generated variables, such as those generated for range-based for loops.`
	`3`	`+* Exclude variables in uninstantiated templates, for which we have no precise data on uses.`
	`4`	`+* Deviations should now be applied to the useless assignment instead of the variable itself.`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -20,6 +20,6 @@ import codingstandards.cpp.deadcode.UselessAssignments`
`20`	`20`
`21`	`21`	`fromSsaDefinitionultimateDef,InterestingStackVariablev`
`22`	`22`	`where`
`23`		`-notisExcluded(v, DeadCodePackage::uselessAssignmentQuery())and`
	`23`	`+notisExcluded(ultimateDef, DeadCodePackage::uselessAssignmentQuery())and`
`24`	`24`	`isUselessSsaDefinition(ultimateDef,v)`
`25`	`25`	`selectultimateDef,"Definition of $@ is unused.",v,v.getName()`

Lines changed: 12 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -112,4 +112,15 @@ int test_useless_assignment(int &x, int p) {`
`112`	`112`	`return y;`
`113`	`113`	`}`
`114`	`114`
`115`		`-intmain() {return0; }`
	`115`	`+intmain() {return0; }`
	`116`	`+`
	`117`	`+#include<vector>`
	`118`	`+template<typename T>voidtest_range_based_for_loop_template() {`
	`119`	`+ std::vector<A> values_;`
	`120`	`+for (auto &elem : values_) {// COMPLIANT - should not report either elem or`
	`121`	`+// the compiler generated (__range)`
	`122`	`+// variable in the uninstantiated`
	`123`	`+// template`
	`124`	`+ elem;`
	`125`	`+ }`
	`126`	`+}`

Lines changed: 5 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,11 @@ class InterestingStackVariable extends StackVariable {`
`43`	`43`	`// A reference parameter can have an affect outside the enclosing function`
`44`	`44`	`notmayEscape(this)and`
`45`	`45`	`// Not a loop control variable, explicitly excluded`
`46`		`-notthisinstanceofLoopControlVariable`
	`46`	`+notthisinstanceofLoopControlVariableand`
	`47`	`+// Ignore variables in uninstantiated templates`
	`48`	`+notthis.isFromUninstantiatedTemplate(_)and`
	`49`	`+// Ignore compiler generated variables, such as those generated for range based for loops`
	`50`	`+notthis.isCompilerGenerated()`
`47`	`51`	`}`
`48`	`52`	`}`
`49`	`53`

Comments

(0)