Commit5ba5f3a

authored

Issue 18: exclude uninstantiated templates (#61)

* Fix issue 18: exclude uninstantiated templates

1 parentd09605b commit5ba5f3aCopy full SHA for 5ba5f3a

File tree

+38

-2

lines changed

+38

-2

lines changed

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	+-`A7-1-1` -`DeclarationUnmodifiedObjectMissingConstSpecifier.ql`:
	`2`	`+- Remove findings in uninstantiated Templates.`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -35,5 +35,6 @@ where`
`35`	`35`	`cond=" points to an object"`
`36`	`36`	`elsecond=" is used for an object"`
`37`	`37`	`)and`
`38`		`-notexists(LambdaExpressionlc\|lc.getACapture().getField()=v)`
	`38`	`+notexists(LambdaExpressionlc\|lc.getACapture().getField()=v)and`
	`39`	`+notv.isFromUninstantiatedTemplate(_)`
`39`	`40`	`selectv,"Non-constant variable "+v.getName()+cond+" and is not modified."`

Lines changed: 34 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -39,9 +39,42 @@ class A7_1_1a final {`
`39`	`39`	`m_ = a.m;`
`40`	`40`	`}`
`41`	`41`	`voidCall() {`
`42`		`- [this]() { std::cout << m_ <<'\n'; }();// COMPLIANT ignore lambdas`
	`42`	`+// ignore lambdas`
	`43`	`+ [this]() { std::cout << m_ <<'\n'; }();// COMPLIANT`
`43`	`44`	`}`
`44`	`45`
`45`	`46`	`private:`
`46`	`47`	`std::string m_;`
`47`	`48`	`};`
	`49`	`+`
	`50`	`+template<typename T>classA7_1_1bfinal {`
	`51`	`+public:`
	`52`	`+explicitA7_1_1b(int i)noexcept {`
	`53`	`+ t_.Init(i);`
	`54`	`+ }// t_ is modified here by Init`
	`55`	`+private:`
	`56`	`+// ignore uninstantiated templates`
	`57`	`+ T t_;// COMPLIANT`
	`58`	`+};`
	`59`	`+`
	`60`	`+classA7_1_1bHelper {`
	`61`	`+public:`
	`62`	`+voidInit(int i) {}`
	`63`	`+};`
	`64`	`+`
	`65`	`+classIssue18 {`
	`66`	`+public:`
	`67`	`+template<typename T>voidF(const T &s) {`
	`68`	`+// ignore uninstantiated templates`
	`69`	`+ std::ostream ostr;// COMPLIANT`
	`70`	`+ ostr << s;// <= Modified here`
	`71`	`+return;`
	`72`	`+ }`
	`73`	`+};`
	`74`	`+`
	`75`	`+/// main`
	`76`	`+intmain(int,char **)noexcept {`
	`77`	`+new A7_1_1b<A7_1_1bHelper>(0);`
	`78`	`+`
	`79`	`+ (new Issue18)->F(0);`
	`80`	`+}`

Comments

(0)