Commit57a2583

authored

Merge branch 'main' into lcartey/no-c90

2 parentsc472266 +4a355fc commit57a2583Copy full SHA for 57a2583

File tree

-8

lines changed

cpp/common/src/codingstandards/cpp/rules/constlikereturnvalue
- ConstLikeReturnValue.qll
c/common/test/rules/constlikereturnvalue
- ConstLikeReturnValue.expected

-8

lines changed

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,7 @@`
`1`	`1`	`problems`
`2`		`-\| test.c:8:8:8:12 \| c_str \|The object returned by the function getenv should not be modified. \|test.c:15:16:15:21 \| call to getenv \|call to getenv \|test.c:8:8:8:12 \| c_str \|c_str \|`
`3`		`-\| test.c:64:5:64:9 \| conv4 \|The object returned by the function localeconv should not be modified. \|test.c:61:11:61:20 \| call to localeconv \|call to localeconv \|test.c:64:5:64:9 \| conv4 \|conv4 \|`
`4`		`-\| test.c:73:5:73:8 \| conv \|The object returned by the function localeconv should not be modified. \|test.c:69:25:69:34 \| call to localeconv \|call to localeconv \|test.c:73:5:73:8 \| conv \|conv \|`
	`2`	`+\| test.c:8:8:8:12 \| c_str \| test.c:15:16:15:21 \| call to getenv \| test.c:8:8:8:12 \| c_str \|The object returned by the function getenv should not be modified. \|`
	`3`	`+\| test.c:64:5:64:9 \| conv4 \| test.c:61:11:61:20 \| call to localeconv \| test.c:64:5:64:9 \| conv4 \|The object returned by the function localeconv should not be modified. \|`
	`4`	`+\| test.c:73:5:73:8 \| conv \| test.c:69:25:69:34 \| call to localeconv \| test.c:73:5:73:8 \| conv \|The object returned by the function localeconv should not be modified. \|`
`5`	`5`	`edges`
`6`	`6`	`\| test.c:5:18:5:22 \| c_str \| test.c:8:8:8:12 \| c_str \|`
`7`	`7`	`\| test.c:15:16:15:21 \| call to getenv \| test.c:21:9:21:12 \| env1 \|`

Lines changed: 2 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -52,16 +52,13 @@ class DFConf extends DataFlow::Configuration {`
`52`	`52`	`}`
`53`	`53`
`54`	`54`	`querypredicateproblems(`
`55`		`-Elemente,stringmessage, DataFlow::PathNodesource,stringsourcetext, DataFlow::PathNodesink,`
`56`		`-stringsinktext`
	`55`	`+Elemente, DataFlow::PathNodesource, DataFlow::PathNodesink,stringmessage`
`57`	`56`	`){`
`58`	`57`	`notisExcluded(e,getQuery())and`
`59`	`58`	`// the modified object comes from a call to one of the ENV functions`
`60`	`59`	`any(DFConfd).hasFlowPath(source,sink)and`
`61`	`60`	`e=sink.getNode().asExpr()and`
`62`	`61`	`message=`
`63`	`62`	`"The object returned by the function "+`
`64`		`-source.getNode().asExpr().(FunctionCall).getTarget().getName()+" should not be modified."and`
`65`		`-sourcetext=source.toString()and`
`66`		`-sinktext=sink.toString()`
	`63`	`+source.getNode().asExpr().(FunctionCall).getTarget().getName()+" should not be modified."`
`67`	`64`	`}`

Comments

(0)