Commit3dc5aa4

committed

Address feedback

1 parent4cc50dd commit3dc5aa4Copy full SHA for 3dc5aa4

File tree

-7

lines changed

-7

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,7 @@ class FunctionAccessExpr extends FunctionAccess, FunctionAccessLikeExpr {`
`47`	`47`	`}`
`48`	`48`
`49`	`49`	`/**`
`50`		`- * Takingan address of a function access in effectively a function access.`
	`50`	`+ * Takingthe address of a function access in effectively a function access.`
`51`	`51`	`*/`
`52`	`52`	`classFunctionAddressExprextendsAddressOfExpr,FunctionAccessLikeExpr{`
`53`	`53`	`Functionfunc;`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -92,7 +92,7 @@ class FunctionGivenToStdExitHandler extends FunctionAccess, SpecialUseOfFunction`
`92`	`92`	`overridestringgetSpecialDescription(Locatableextra,stringextraString){`
`93`	`93`	`result="$@"and`
`94`	`94`	`extra=exitHandlerCalland`
`95`		`-extraString="passed exit handler std::"+exitHandler.getName()`
	`95`	`+extraString="passedto theexit handler std::"+exitHandler.getName()`
`96`	`96`	`}`
`97`	`97`	`}`
`98`	`98`

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -15,6 +15,7 @@`
`15`	`15`
`16`	`16`	`import cpp`
`17`	`17`	`import codingstandards.cpp.misra`
	`18`	`+import codingstandards.cpp.EncapsulatingFunctions`
`18`	`19`	`import codingstandards.cpp.exceptions.ExceptionFlow`
`19`	`20`	`import codingstandards.cpp.exceptions.ExceptionSpecifications`
`20`	`21`
`@@ -24,7 +25,7 @@ import codingstandards.cpp.exceptions.ExceptionSpecifications`
`24`	`25`	`*/`
`25`	`26`	`classUncaughtFunctionCallInMainextendsFunctionCall{`
`26`	`27`	`UncaughtFunctionCallInMain(){`
`27`		`-getEnclosingFunction().hasName("main")and`
	`28`	`+getEnclosingFunction()instanceofMainFunctionand`
`28`	`29`	`notisNoExceptTrue(getTarget())and`
`29`	`30`	`notexists(TryStmttry\|`
`30`	`31`	`try=getATryStmt(this.getEnclosingStmt())and`
`@@ -46,10 +47,9 @@ class UncaughtFunctionCallInMain extends FunctionCall {`
`46`	`47`	`}`
`47`	`48`	`}`
`48`	`49`
`49`		`-fromFunctionf,UncaughtFunctionCallInMainfc`
	`50`	`+fromMainFunctionf,UncaughtFunctionCallInMainfc`
`50`	`51`	`where`
`51`	`52`	`notisExcluded(f, Exceptions3Package::missingCatchAllExceptionHandlerInMainQuery())and`
`52`		`-f.getName()="main"and`
`53`	`53`	`fc.isFirst()`
`54`	`54`	`selectf,`
`55`	`55`	`"Main function has a $@ which is not within a try block with a catch-all ('catch(...)') handler.",`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,7 @@`
`1`	`1`	`/**`
`2`	`2`	`* @id cpp/misra/exception-unfriendly-function-must-be-noexcept`
`3`	`3`	`* @name RULE-18-4-1: Exception-unfriendly functions shall be noexcept`
`4`		`- * @description Throwing exceptions in constructors,descructors, copy-constructors, move`
	`4`	`+ * @description Throwing exceptions in constructors,destructors, copy-constructors, move`
`5`	`5`	`* constructors, assignments, and functions named swap, may result in`
`6`	`6`	`* implementation-defined behavior.`
`7`	`7`	`* @kind problem`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,7 @@`
`50`	`50`	`},`
`51`	`51`	`"queries": [`
`52`	`52`	`{`
`53`		`-"description":"Throwing exceptions in constructors,descructors, copy-constructors, move constructors, assignments, and functions named swap, may result in implementation-defined behavior.",`
	`53`	`+"description":"Throwing exceptions in constructors,destructors, copy-constructors, move constructors, assignments, and functions named swap, may result in implementation-defined behavior.",`
`54`	`54`	`"kind":"problem",`
`55`	`55`	`"name":"Exception-unfriendly functions shall be noexcept",`
`56`	`56`	`"precision":"very-high",`

Comments

(0)