Enable Feature.DiffInformedQueries#2970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

cklin merged 4 commits intomainfromcklin/diff-informed-feature-enable

Jul 17, 2025

Merged

Enable Feature.DiffInformedQueries#2970

cklin merged 4 commits intomainfromcklin/diff-informed-feature-enable

Jul 17, 2025

Conversation

Copy link

Contributor

cklin commentedJul 14, 2025•
edited
Loading

This PR updatesFeature.DiffInformedQueries to be enabled on GHES versions 3.19 or higher.

Merge / deployment checklist

Confirm this change is backwards compatible with existing workflows.
Confirm thereadme has been updated if necessary.
Confirm thechangelog has been updated if necessary.

cklin marked this pull request as ready for review

July 14, 2025 19:10

CopilotAI review requested due to automatic review settings

July 14, 2025 19:10

cklin requested a review froma team as acode owner

July 14, 2025 19:10

This comment was marked as outdated.

cklin requested a review frommbg

July 14, 2025 19:11

cklin force-pushed thecklin/diff-informed-feature-enable branch from91304fa to56692c1Compare

July 16, 2025 18:10

cklin requested a review fromCopilot

July 16, 2025 18:12

CopilotAI reviewed

Jul 16, 2025

View reviewed changes

Copy link

Contributor

CopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull Request Overview

This PR enables theFeature.DiffInformedQueries feature by default and restricts it to GHES versions 3.19 or higher. The primary goal is to make diff-informed queries available to more users while ensuring compatibility with supported GHES versions.

Changed the default value forFeature.DiffInformedQueries fromfalse totrue
Added GHES version checking to restrict the feature to version 3.19 or higher
Added comprehensive test coverage for the new GHES version validation logic

Reviewed Changes

Copilot reviewed 6 out of 9 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
src/feature-flags.ts	Updates default value for DiffInformedQueries feature from false to true
src/diff-informed-analysis-utils.ts	Adds GHES version checking logic to restrict feature to 3.19+
src/diff-informed-analysis-utils.test.ts	Adds comprehensive test cases for diff-informed analysis functionality
lib/feature-flags.js	Compiled JavaScript version of the TypeScript feature flag changes
lib/diff-informed-analysis-utils.test.js	Compiled JavaScript version of the TypeScript test file
lib/diff-informed-analysis-utils.js	Compiled JavaScript version of the TypeScript utility changes