- Notifications
You must be signed in to change notification settings - Fork358
Bump minimum CodeQL version to 2.16.6#2912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
henrymercer wants to merge6 commits intomainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull Request Overview
This PR raises the minimum supported CodeQL CLI version to 2.16.6, removes legacy guards and features for older releases, and updates CI/test matrices and the action version accordingly.
- Remove version checks and feature flags for CodeQL ≤ 2.16.5
- Add stable-v2.20.7 to defaultTestVersions and workflow matrices; drop v2.15.5
- Bump action minor version to 3.29.0 and record in CHANGELOG
Reviewed Changes
Copilot reviewed 41 out of 41 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/analyze.ts | Drop redundant supportsFeature guard around build-mode tracing |
| pr-checks/sync.py | Remove stable-v2.15.5, add stable-v2.20.7 in defaultTestVersions |
| pr-checks/checks/cpp-deptrace-enabled-on-macos.yml | Include “linked” as a valid version for macOS C/C++ deptrace check |
| package.json | Bump action version from 3.28.19 to 3.29.0 |
| lib/tracer-config.js | Simplify getCombinedTracerConfig; remove CODEQL_RUNNER fallback logic |
| lib/tracer-config.test.js | Rename test and drop outdated runner-env tests |
| lib/tools-features.js | Remove deprecated ToolsFeature flags |
| lib/tools-features.test.js | Update test to cover new ForceOverwrite flag |
| lib/init.js | Eliminate printPathFiltersWarning export and refactor initConfig grouping |
| lib/init.test.js | Remove tests for deprecated path-filters warning |
| lib/init-action.js | Streamline debug options; remove Go static-binary wrapper |
| lib/autobuild.js | Remove legacy feature check, simplify autobuild decision logic |
| lib/analyze.js | Remove unused import and obsolete supportsFeature check |
| lib/codeql.js | Bump CODEQL_MINIMUM_VERSION to 2.16.6; drop buildModeOption guard |
| CHANGELOG.md | Add “Bump minimum CodeQL bundle version to 2.16.6” entry |
| .github/workflows/__multi-language-autodetect.yml | Remove v2.15.5 matrix entries; add v2.20.7 |
| .github/workflows/__go-tracing-legacy-workflow.yml | Remove v2.15.5 entries; add v2.20.7 |
| .github/workflows/__go-tracing-custom-build-steps.yml | Remove v2.15.5 entries; add v2.20.7 |
| .github/workflows/__go-tracing-autobuilder.yml | Remove v2.15.5 entries; add v2.20.7 |
| .github/workflows/__cpp-deptrace-enabled-on-macos.yml | Add matrix entry for version “linked” on macOS |
Comments suppressed due to low confidence (2)
pr-checks/sync.py:11
- Update this comment to point at the actual file where
CODEQL_MINIMUM_VERSIONlives (now inlib/codeql.js), so future bumps aren’t missed.
# The oldest supported CodeQL version. If bumping, update `CODEQL_MINIMUM_VERSION` in `codeql.ts`lib/tracer-config.test.js:62
- Consider adding a test that validates the returned
envobject matches the contents ofstart-tracing.json(e.g. ensureCODEQL_DISTandCODEQL_PLATFORMare mapped correctly), to retain full coverage of tracer-config behavior.
(0, ava_1.default)("getCombinedTracerConfig", async (t) => {ed2a3d0 tod54c5e2CompareNote that this PR updates the set of required checks — we'll need to followthese steps before merging. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR bumps the minimum CodeQL version to 2.16.6, as announced by#2859.
Merge / deployment checklist