Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Allow configuring CODEQL_THREADS with an env var#2891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
aeisenberg merged 5 commits intogithub:mainfromaustinpray-mixpanel:patch-1
May 14, 2025

Conversation

austinpray-mixpanel
Copy link
Contributor

@austinpray-mixpanelaustinpray-mixpanel commentedMay 6, 2025
edited
Loading

closes#2890

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm thereadme has been updated if necessary.
  • Confirm thechangelog has been updated if necessary.

@CopilotCopilotAI review requested due to automatic review settingsMay 6, 2025 02:29
@austinpray-mixpanelaustinpray-mixpanel requested a review froma team as acode ownerMay 6, 2025 02:29
Copy link
Contributor

@CopilotCopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull Request Overview

This PR enables configuring the number of CodeQL threads via an environment variable.

  • Allows users to override the thread count using CODEQL_THREADS in the environment.
  • Falls back to computing the thread value based on the "threads" input if the env var is not set.

Copy link
Contributor

@aeisenbergaeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for your PR. I don't think this is harmful or could break anything, but it seems a bit redundant.

Can you try this alternate approach?

In theinit/actions.yml file adddefault: "${{ env.CODEQL_THREADS }}" to thethreads input. This should be sufficient.

@austinpray-mixpanel
Copy link
ContributorAuthor

Thanks for your PR. I don't think this is harmful or could break anything, but it seems a bit redundant.

Can you try this alternate approach?

In theinit/actions.yml file adddefault: "${{ env.CODEQL_THREADS }}" to thethreads input. This should be sufficient.

Yep I can give this a shot. My initial change was just trying to match up the way the ram variable was treated

@aeisenberg
Copy link
Contributor

Yep I can give this a shot. My initial change was just trying to match up the way the ram variable was treated

Great. Let me know if this works for you. Now that I'm engaged, I'll be able to respond more quickly to this PR.

@austinpray-mixpanel
Copy link
ContributorAuthor

@aeisenberg lmk what you think 👍

aeisenberg
aeisenberg previously approved these changesMay 13, 2025
Copy link
Contributor

@aeisenbergaeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This looks right to me.

@austinpray-mixpanel
Copy link
ContributorAuthor

@aeisenberg ah I don't think you can use env variable expressions in inputs

Error: /Users/runner/work/codeql-action/codeql-action/./../action/init/action.yml (Line: 118, Col: 14): Unrecognized named-value: 'env'. Located at position 1 within expression: env.CODEQL_THREADS

@aeisenberg
Copy link
Contributor

Oh...that's really unfortunate. Apologies for the confusion. I'm asking internally what's going on since this is a pattern that'sbeing used elsewhere.

@aeisenbergaeisenberg added RebuildRe-transpile JS & re-generate workflows and removed RebuildRe-transpile JS & re-generate workflows labelsMay 14, 2025
@aibaars
Copy link
Collaborator

Oh...that's really unfortunate. Apologies for the confusion. I'm asking internally what's going on since this is a pattern that'sbeing used elsewhere.

Most of those examples commented out thedefault field with a# though. I'm not sure why theenv context is not allowed, perhaps it is not available until a workflow starts to "run".

@austinpray-mixpanel
Copy link
ContributorAuthor

In any case it probably makes sense to have the threads and ram behavior configuration be exactly the same so there aren't any surprises
image

@henrymercerhenrymercer added RebuildRe-transpile JS & re-generate workflows and removed RebuildRe-transpile JS & re-generate workflows labelsMay 14, 2025
@henrymercer
Copy link
Contributor

Thanks for the contribution@austinpray-mixpanel! Could you follow the instructions inhttps://github.com/github/codeql-action/blob/main/CONTRIBUTING.md#common-tasks to rebuild the project?

@austinpray-mixpanel
Copy link
ContributorAuthor

@henrymercer done 👍

@henrymercerhenrymercer removed the RebuildRe-transpile JS & re-generate workflows labelMay 14, 2025
@aeisenbergaeisenberg merged commitcffc916 intogithub:mainMay 14, 2025
265 checks passed
@austinpray-mixpanel
Copy link
ContributorAuthor

Thank you all!

@github-actionsgithub-actionsbot mentioned this pull requestMay 16, 2025
8 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

Copilot code reviewCopilotCopilot left review comments

@aeisenbergaeisenbergaeisenberg approved these changes

@henrymercerhenrymercerhenrymercer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No way to configure CODEQL_THREADS with an environment variable
4 participants
@austinpray-mixpanel@aeisenberg@aibaars@henrymercer

[8]ページ先頭

©2009-2025 Movatter.jp