- Notifications
You must be signed in to change notification settings - Fork373
Update supported GitHub Enterprise Server versions#2859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull Request Overview
This PR updates the supported GitHub Enterprise Server (GHES) versions and bumps CodeQL minimum requirements across source, compiled artifacts, and documentation.
- Bump
CODEQL_NEXT_MINIMUM_VERSION
,GHES_VERSION_MOST_RECENTLY_DEPRECATED
, and deprecation date insrc/codeql.ts
andlib/codeql.js
. - Update
minimumVersion
inapi-compatibility.json
(source and lib) from 3.12 to 3.13. - Refresh the README table of supported GHES versions and matching Action/Bundle versions.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
src/codeql.ts | Updated CodeQL/GHES version constants |
src/api-compatibility.json | Bumped minimum GHES API compatibility to 3.13 |
lib/codeql.js | Mirrored version constant updates in compiled JS |
lib/api-compatibility.json | Mirrored minimumVersion bump in compiled JSON |
README.md | Refreshed table with new Action/Bundle and GHES entries |
Comments suppressed due to low confidence (3)
src/codeql.ts:288
- Consider centralizing version constants in a single module or configuration file to avoid having to update both the TypeScript source and its compiled JavaScript duplicate.
const CODEQL_NEXT_MINIMUM_VERSION = "2.16.6";
lib/codeql.js:81
- Since this value is duplicated from the TypeScript source, centralizing would eliminate manual sync and reduce risk of mismatches.
const CODEQL_NEXT_MINIMUM_VERSION = "2.16.6";
README.md:75
- [nitpick] The same Action and Bundle versions are repeated for multiple GHES releases; consider combining rows (e.g., "3.13–3.16") to reduce duplication and improve table readability.
| `v3.28.6` | `2.20.3` | Enterprise Server 3.15 | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks plausible, thought I did not double check the versions - if that's required I'd need help on how
83bdf3b
intomainUh oh!
There was an error while loading.Please reload this page.
This PR updates the list of supported GitHub Enterprise Server versions, either because a new version is about to be feature frozen, or because an old release has been deprecated.
If an old release has been deprecated, please follow the instructions in CONTRIBUTING.md to deprecate the corresponding version of CodeQL.