- Notifications
You must be signed in to change notification settings - Fork373
Use an app token for triggering a release#2644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no suggestions.
Comments skipped due to low confidence (1)
.github/workflows/post-release-mergeback.yml:166
- The new token generation step should be tested to ensure it works as expected. Consider adding a test workflow to validate the token creation process.
uses: actions/create-github-app-token@5d869da34e18e7287c1daad50e0b8ea0f506ce69Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab.Learn more
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The indentation doesn't look quite right, but otherwise this looks good!
We need to do this because using a default token will notrecursively trigger a new workflow run.
1a19005 to9a8645dCompareFixed the indentation. After merging, I will do a release to see if this fixes the problem. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Code-wise, this looks good.
The only question is whether the permissions are adequate for performing the release, but I guess we won't know until we try it.
9cfbef4 intomainUh oh!
There was an error while loading.Please reload this page.
I believe so. We need |
We need to do this because using a default token will not recursively trigger a new workflow run.
The only way to test this is to merge to main and do a release.
Merge / deployment checklist