Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Start Proxy: Make the post step more robust to errors#2643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
marcogario merged 3 commits intomainfrommarcogario/robustify_start_proxy_post
Dec 11, 2024

Conversation

marcogario
Copy link
Contributor

The post step of the start-proxy action tries to kill the proxy process and, when run in debug mode, uploads a log file as artifact. This PR makes failures in either of those operations non-fatal. Moreover, it extends the manifest for the action to include the github token that is required to upload the artifact itself.

This action is used internally, so I don't think a changelog entry is needed, but happy to copy a summary of ^.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm thereadme has been updated if necessary.
  • Confirm thechangelog has been updated if necessary.

@marcogariomarcogarioforce-pushed themarcogario/robustify_start_proxy_post branch fromd0a1f42 to47dd68eCompareDecember 11, 2024 15:12
@marcogariomarcogario marked this pull request as ready for reviewDecember 11, 2024 15:21
@marcogariomarcogario requested a review froma team as acode ownerDecember 11, 2024 15:21
@marcogariomarcogario requested review fromaibaars and removed request fora teamDecember 11, 2024 15:21
@marcogariomarcogario merged commit78d0136 intomainDec 11, 2024
522 checks passed
@marcogariomarcogario deleted the marcogario/robustify_start_proxy_post branchDecember 11, 2024 17:01
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@aibaarsaibaarsaibaars approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@marcogario@aibaars

[8]ページ先頭

©2009-2025 Movatter.jp