- Notifications
You must be signed in to change notification settings - Fork1.9k
Comments
Go: Remove toolchain directive fromgo/extractor/go.mod#21307
Open
owen-mc wants to merge 1 commit intogithub:mainfrom
Open
Go: Remove toolchain directive fromgo/extractor/go.mod#21307owen-mc wants to merge 1 commit intogithub:mainfrom
go/extractor/go.mod#21307owen-mc wants to merge 1 commit intogithub:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull request overview
Removes the Gotoolchain directive fromgo/extractor/go.mod to avoid pinning the extractor module to a specific patch version, aligning with the goal of always using the latest patch release for thego 1.26 directive.
Changes:
- Remove
toolchain go1.26.0fromgo/extractor/go.mod.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Currently the toolchain directive (
toolchain go1.26.0) has no effect, but when the next patch release 1.26.1 comes out I think it will actually keep us using 1.26.0. I have a plan to make sure we always use the latest patch release for the language version specified in the go directive (go 1.26), and it requires that this toolchain directive is removed.