NotificationsYou must be signed in to change notification settings
Fork1.7k
Star8.5k

Java: Restrict results to source literals.#20054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

aschackmull merged 1 commit intogithub:mainfromaschackmull:java/fixup-control-char-query

Jul 15, 2025

Merged

Java: Restrict results to source literals.#20054

aschackmull merged 1 commit intogithub:mainfromaschackmull:java/fixup-control-char-query

Jul 15, 2025

+4 −0

Conversation

Copy link

Contributor

aschackmull commentedJul 15, 2025

Some literals extracted from.class files can contain many control chars, which can cause this query to blow up. Those results are pretty useless, so we can simply exclude them.

Java: Restrict results to source literals.

9e87095

CopilotAI review requested due to automatic review settings

July 15, 2025 12:56

aschackmull added the no-change-note-requiredThis PR does not need a change note label

Jul 15, 2025

aschackmull requested a review froma team as acode owner

July 15, 2025 12:56

CopilotAI reviewed

Jul 15, 2025

View reviewed changes

Copy link

Contributor

CopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull Request Overview

This PR restricts a CodeQL query to only analyze source literals rather than compiled bytecode literals. The change addresses performance issues caused by literals extracted from.class files that contain many control characters, which can cause the query to become inefficient while providing limited value.

Adds a filter to restrict analysis to source compilation units only
Adds documentation explaining why Kotlin files are excluded to prevent false positives