- Notifications
You must be signed in to change notification settings - Fork1.7k
Go: Fix compilation of DataFlowImplConsistency.qll#20053
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull Request Overview
This PR fixes a compilation error in the DataFlowImplConsistency.qll file by adding a module alias to resolve naming conflicts. The fix addresses the issue reported in GitHub issue#19890 where the file failed to compile due to ambiguous references toGoDataFlow.
- Adds an alias
Implfor theDataFlowImplSpecificimport to disambiguate references - Updates references to
GoDataFlowto use the qualified nameImpl::GoDataFlow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM. Not sure how much weight my review carries 😄
53e1939 intogithub:mainUh oh!
There was an error while loading.Please reload this page.
As pointed out in#19890, this file didn't compile.