Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Java: useoverlayChangedFiles in discard prediactes#20049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nickrolfe merged 1 commit intomainfromnickrolfe/java-deleted-files
Jul 15, 2025

Conversation

nickrolfe
Copy link
Contributor

@nickrolfenickrolfe commentedJul 15, 2025•
edited
Loading

This should improve accuracy of overlay analysis, since we'll now correctly discard entities from files that were deleted.

@nickrolfenickrolfe added the no-change-note-requiredThis PR does not need a change note labelJul 15, 2025
@nickrolfenickrolfe marked this pull request as ready for reviewJuly 15, 2025 09:38
@CopilotCopilotAI review requested due to automatic review settingsJuly 15, 2025 09:38
@nickrolfenickrolfe requested a review froma team as acode ownerJuly 15, 2025 09:38
Copy link
Contributor

@CopilotCopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull Request Overview

This PR refactors the overlay system by replacing theextractedInOverlay predicate with the existingoverlayChangedFiles predicate for determining which files should be discarded in the base variant.

  • Removes theextractedInOverlay predicate definition
  • Updates discard predicates to useoverlayChangedFiles instead ofextractedInOverlay

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

FileDescription
java/ql/lib/semmle/code/java/Overlay.qllRemovesextractedInOverlay predicate and updates two discard predicates to useoverlayChangedFiles
java/ql/lib/semmle/code/Location.qllUpdates location discard predicate to useoverlayChangedFiles

@kaspersv
Copy link
Contributor

Improves non-diff-informed overlay accuracy from99.2% to99.4% for Java's code scanning suite based on DCA experiments.

@nickrolfenickrolfe merged commit16e9e8e intomainJul 15, 2025
19 checks passed
@nickrolfenickrolfe deleted the nickrolfe/java-deleted-files branchJuly 15, 2025 11:42
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

Copilot code reviewCopilotCopilot left review comments

@kaspersvkaspersvkaspersv approved these changes

Assignees

@kaspersvkaspersv

Labels
Javano-change-note-requiredThis PR does not need a change note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@nickrolfe@kaspersv
[8]ページ先頭
©2009-2025 Movatter.jp