Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

C++: Fix C++20 concept related class extensions#20026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jketema merged 1 commit intogithub:mainfromjketema:concept-fix
Jul 13, 2025

Conversation

jketema
Copy link
Contributor

@jketemajketema commentedJul 11, 2025•
edited
Loading

Noted by@MathiasVP on Slack.

  • RequirementExpr was missing a charpred, or wasn't abstract. I added a charpred.
  • NestedRequirementExpr accidentally didn't extendRequirementExpr
  • ConceptIdExpr accidentally did extendRequirementExpr (while it can occur in other contexts)

@jketemajketema added the no-change-note-requiredThis PR does not need a change note labelJul 11, 2025
@jketemajketema marked this pull request as ready for reviewJuly 11, 2025 11:45
@CopilotCopilotAI review requested due to automatic review settingsJuly 11, 2025 11:45
@jketemajketema requested a review froma team as acode ownerJuly 11, 2025 11:45
Copy link
Contributor

@CopilotCopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull Request Overview

This PR fixes C++20 concept-related class extensions in the CodeQL library by correcting the inheritance hierarchy for requirement expressions. The changes ensure that all requirement expression classes properly inherit fromRequirementExpr and eliminate redundant parent checks.

Key changes:

  • Adds constructor logic toRequirementExpr to establish proper parent-child relationships
  • Refactors requirement expression classes to use the base class constructor instead of duplicating parent checks
  • Corrects the inheritance hierarchy forNestedRequirementExpr andConceptIdExpr

Copy link
Contributor

@IdrissRioIdrissRio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

DCA is happy and LGTM 👍

@jketemajketema merged commitd82d5c2 intogithub:mainJul 13, 2025
18 checks passed
@jketemajketema deleted the concept-fix branchJuly 13, 2025 08:20
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

Copilot code reviewCopilotCopilot left review comments

@IdrissRioIdrissRioIdrissRio approved these changes

Assignees
No one assigned
Labels
C++no-change-note-requiredThis PR does not need a change note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@jketema@IdrissRio
[8]ページ先頭
©2009-2025 Movatter.jp