Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Overlay: Add XML and Java property discarding#20011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
kaspersv merged 3 commits intogithub:mainfromkaspersv:kaspersv/discard-xml
Jul 15, 2025

Conversation

kaspersv
Copy link
Contributor

@kaspersvkaspersv commentedJul 10, 2025•
edited
Loading

This PR adds discard predicates for Java to discard XML locatables and Java properties. XML and Java property extraction is not incremental and the overlay therefore contains a full XML and Java property extraction during overlay analysis. If the overlay contains any XML locatables, all XML locatables are discarded from base, and likewise for Java properties.

Overlay compilation is currently disabled for Java and the discard predicates currently have no effect on compilation or evaluation.

Forhttps://github.com/github/codeql-core/issues/5003.

@kaspersvkaspersv marked this pull request as ready for reviewJuly 14, 2025 06:10
@kaspersvkaspersv requested a review froma team as acode ownerJuly 14, 2025 06:10
@kaspersvkaspersv added the no-change-note-requiredThis PR does not need a change note labelJul 14, 2025
Co-authored-by: Anders Schack-Mulligen <aschackmull@users.noreply.github.com>
Copy link
Contributor

@aschackmullaschackmull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

One minor nit, otherwise looks plausible.

@kaspersvkaspersv merged commit9c3e275 intogithub:mainJul 15, 2025
16 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@aschackmullaschackmullaschackmull approved these changes

Assignees

@aschackmullaschackmull

Labels
Javano-change-note-requiredThis PR does not need a change note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@kaspersv@aschackmull
[8]ページ先頭
©2009-2025 Movatter.jp