Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Make a proper shared library out of the concept related libraries#19984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jketema merged 9 commits intogithub:mainfromjketema:jketema/sec-shared
Jul 17, 2025

Conversation

jketema
Copy link
Contributor

@jketemajketema commentedJul 6, 2025•
edited
Loading

Observe that to turn theConceptsShared.qll into a parameterized module I had to introduce

finalprivateclassDataFlowNode= DataFlowLang::Node;

(seehttps://github.com/github/codeql/pull/19984/files#diff-ab7ead61741aa4309d3f7c41942166168e0c46d9fe16b1f6e8089e251eba90caR20) This has an impact on some places whereConceptsShared.qll, as it becomes impossible to useextends in various places. So I opted for usinginstanceof instead. The latter might explain some of the changes in stage timings visible in the DCA results. Overall analysis time does not seem to be impacted though.

@github-actionsgithub-actionsbot added JS Python Ruby RustPull requests that update Rust code Swift labelsJul 6, 2025
@jketemajketemaforce-pushed thejketema/sec-shared branch 4 times, most recently fromeb7ba6b to05a28b9CompareJuly 9, 2025 14:13
@jketemajketemaforce-pushed thejketema/sec-shared branch 3 times, most recently from05f694f to33f874eCompareJuly 14, 2025 14:28
@jketemajketema changed the titlesec sharedMake a proper shared library out of the concept related librariesJul 16, 2025
@geoffw0
Copy link
Contributor

I reviewed all of the DCA runs and nothing seems to be amiss. 👍

@jketemajketema marked this pull request as ready for reviewJuly 16, 2025 09:42
@jketemajketema requested review froma team ascode ownersJuly 16, 2025 09:42
@jketemajketema requested a review froma team as acode ownerJuly 16, 2025 09:42
aschackmull
aschackmull previously approved these changesJul 16, 2025
Copy link
Contributor

@aschackmullaschackmull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

QL changes LGTM

The import should not have been private, because we want users to still beable to import this file and have access to the crypto algorithms.
Copy link
Contributor

@geoffw0geoffw0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks great, I was surprised how little per-language customization is needed on things likeConceptsShared - but I guess they're build atop shared dataflow.

@jketema
Copy link
ContributorAuthor

Going ahead and merging this. The coding standards failures are not related to these changes.

owen-mc and geoffw0 reacted with hooray emoji

@jketemajketema merged commitacc66c7 intogithub:mainJul 17, 2025
55 of 56 checks passed
@jketemajketema deleted the jketema/sec-shared branchJuly 17, 2025 11:25
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@aschackmullaschackmullaschackmull approved these changes

@geoffw0geoffw0geoffw0 approved these changes

Assignees
No one assigned
Labels
documentationJSPythonRubyRustPull requests that update Rust codeSwift
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@jketema@geoffw0@aschackmull
[8]ページ先頭
©2009-2025 Movatter.jp