Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

C++: Generate flow summaries forcurl/curl#19596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
MathiasVP wants to merge3 commits intogithub:mainfromMathiasVP:add-curl-models

Conversation

MathiasVP
Copy link
Contributor

Similar to what we did in#19492, but forcurl/curl.

I've used the database coming from DCA to generate the models.

@CopilotCopilotAI review requested due to automatic review settingsMay 27, 2025 11:54
@MathiasVPMathiasVP requested a review froma team as acode ownerMay 27, 2025 11:54
Copy link
Contributor

@CopilotCopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@jketema
Copy link
Contributor

I assume you generated these based on the slug we have in DCA? If so, did you check that the autobuild configuration we use there actually makes sort-of sense, and is not a configuration that disables a lot of things?

@MathiasVP
Copy link
ContributorAuthor

MathiasVP commentedMay 27, 2025
edited
Loading

I assume you generated these based on the slug we have in DCA? If so, did you check that the autobuild configuration we use there actually makes sort-of sense, and is not a configuration that disables a lot of things?

Yeah, I used the slug from DCA. I briefly checked that the (arguably few) summaries I expected to be there were present, but I didn't investigate whether the autobuild configuration made sense. I'm happy to spend some time investigating this before we merge this PR

@jketema
Copy link
Contributor

I'm happy to spend some time investigating this before we merge this PR

I think that would make sense.

I also see you have some test failures.

MathiasVP reacted with thumbs up emoji

@MathiasVPMathiasVP marked this pull request as draftMay 27, 2025 12:19
@MathiasVP
Copy link
ContributorAuthor

Thanks. (Luckily those files are simply changes that needs to be accepted!)

I see that the autobuilder is trying to run:

-DCMAKE_VERBOSE_MAKEFILE=ON -DBUILD_DOCS=OFF -DCATKIN_ENABLE_TESTING=OFF -DBUILD_DOCUMENTATION=OFF -DCMAKE_BUILD_TYPE=Release -DCMAKE_CXX_FLAGS= -DCMAKE_C_FLAGS=

This looks fairly sensible. In particular, it doesn't disable any non-documentation/non-testing features.

What I did notice was that curl (obviously) depends on a lot of other more low-level libraries that we may want to add models for first. The ones I recognized were:

  • google/brotli
  • madler/zlib
  • nghttp2/nghttp2
  • libidn/libidn2
  • libssh2/libssh2
  • libuv/libuv

I think it's high time that I reorganize the DCA repositories relevant for MaD generation slightly better so that we can get all of these dependencies modeled first. So I think I'll work on that.

jketema reacted with thumbs up emoji

@jketema
Copy link
Contributor

Thanks for looking at the DCA configuration. I see you moved this back into draft. Is your intention to add models for the used libraries first, before continuing with this?

@MathiasVP
Copy link
ContributorAuthor

Thanks for looking at the DCA configuration. I see you moved this back into draft. Is your intention to add models for the used libraries first, before continuing with this?

Yeah, I think I want to do that to ensure that we get the proper models

@MathiasVP
Copy link
ContributorAuthor

Superseded by#19753

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

Copilot code reviewCopilotCopilot left review comments

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@MathiasVP@jketema

[8]ページ先頭

©2009-2025 Movatter.jp