- Notifications
You must be signed in to change notification settings - Fork1.7k
Rust: upgraderust-analyzer to 0.0.281#19524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
cc2e8ab to28b504aComparerust-analyzer to 0.0.279rust-analyzer to 0.0.281There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
QL changes LGTM.
I've raised some questions on the DCA run, it looks like a net gain but there are some regressions in there that deserve discussing.
Extractor changes not reviewed.
| @@ -1,4 +1,6 @@ | |||
| testFailures | |||
| | main.rs:1244:26:1244:53 | //... | Missing result: method=abs | | |||
| | main.rs:1244:26:1244:53 | //... | Missing result: type=z:i32 | | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Is this regression understood?
This is in draft sitting on top of#19314 and#19506.