Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Delete Automodel Queries#18022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
kaeluka merged 2 commits intomainfromkaeluka/4648-remove-automodel-queries
Nov 22, 2024
Merged

Conversation

@kaeluka
Copy link

@kaelukakaeluka commentedNov 19, 2024•
edited
Loading

Note

Dear reviewer:

  • I would be surprised if anyone other than us would use these queries, but they were public and that means dropping them should get a change note.
  • To do that, this PR only removes the queries and qlpack files, but it leaves the change log directory in place so that I can write a change note about this packages' removal. Are you aware of any automation or expectations this might break?
  • I think we should remove the change log directory as well after the next release was done and the change log message has been distributed to users, right? Or should the directory stay there?

Pull Request checklist

All query authors

Internal query authors only

  • Autofixes generated based on these changes are valid, only needed if this PR makes significant changes to.ql,.qll, or.qhelp files. Seethe documentation (internal access required).
  • Changes are validatedat scale (internal access required).
  • Adding a new query? Consider alsoadding the query to autofix.

@kaelukakaelukaforce-pushed thekaeluka/4648-remove-automodel-queries branch from0e4f045 to4208f03CompareNovember 19, 2024 09:40
@kaelukakaeluka marked this pull request as ready for reviewNovember 19, 2024 10:42
@kaelukakaeluka requested a review froma team as acode ownerNovember 19, 2024 10:42
Copy link
Contributor

@aeisenbergaeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM.

These queries were last published in August 2023.https://github.com/orgs/codeql/packages?tab=packages&q=java-automodel-queries

If anyone is relying on these queries, then they can use the published variants of them. Since we are not including these queries in the bundle, I'd be extremely surprised if someone is using them from this repo.

@kaeluka
Copy link
Author

Thank you, Andrew! I'm leaving this open until tomorrow ~lunch time in case the @github/codeql-java team has comments as well. Then I'll merge 👍

@kaelukakaeluka merged commit30581d7 intomainNov 22, 2024
12 checks passed
@kaelukakaeluka deleted the kaeluka/4648-remove-automodel-queries branchNovember 22, 2024 09:13
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@aeisenbergaeisenbergaeisenberg approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kaeluka@aeisenberg
[8]ページ先頭
©2009-2025 Movatter.jp