- Notifications
You must be signed in to change notification settings - Fork1.9k
Go: improve path summary by changing post update nodes#13473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Go: improve path summary by changing post update nodes#13473
Uh oh!
There was an error while loading.Please reload this page.
Conversation
4843d1c to9ea23c1Compare| MkImplicitVarargsSlice(CallExprc){c.hasImplicitVarargs()}or | ||
| MkFlowSummaryNode(FlowSummaryImpl::Private::SummaryNodesn) | ||
| MkFlowSummaryNode(FlowSummaryImpl::Private::SummaryNodesn)or | ||
| MkPostUpdateNode(IR::Instructioninsn){insn=updatedInstruction()} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
getAnUpdatedInstruction
| result= IR::evalExprInstruction(any(SendStmts).getChannel()) | ||
| } | ||
| private IR::InstructiongetAccessPathPredecessor2(IR::Instructioninsn){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks like getAWrittenNode is now unused, so we could remove that and getAccessPathPredecessor then remove the2 here
| result=getAWrittenInstruction() | ||
| } | ||
| privateExprupdatedExpr(){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
getAn...
9ea23c1 to9e4f4faCompareowen-mc commentedOct 3, 2025
Not needed now we have proper post-update nodes in#14751. |
Cf.this comment and the surrounding discussion.
This PR adds new data-flow nodes which are used for post-update nodes. This means that the post-update node will now be in the expected place. This should make path summaries easier to understand.