- Notifications
You must be signed in to change notification settings - Fork700
Ability to set deployedsha1file instead of hardcoded. Both command li…#605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…ne and through config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you!
I left a couple of comments.
| DEPLOYED_SHA1_FILE="$(get_config deployedsha1file"$DEPLOYED_SHA1_FILE")" | ||
| DEPLOYED_SHA1_FILE_CONFIG="$(get_config deployedsha1file)" | ||
| if [-z"$DEPLOYED_SHA1_FILE_CONFIG" ];then | ||
| DEPLOYED_SHA1_FILE="$(get_config deployedsha1file"$DEPLOYED_SHA1_FILE")"#If none in config, rerun with harcoded value | ||
| else | ||
| DEPLOYED_SHA1_FILE=$DEPLOYED_SHA1_FILE_CONFIG | ||
| fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I don't understand this change. The old line should have done exactly the same. If the config variable is set then$(get_config deployedsha1file "$DEPLOYED_SHA1_FILE") will return the config option. If it's not set then it will return the original value of$DEPLOYED_SHA1_FILE.
| --enable-post-errorsFails if post-ftp-push hook raises an error | ||
| --disable-epsvTell curl to disable the use of the EPSV command when doing passive FTP transfers. Curl will normally always first attempt to use EPSV before PASV, but with this option, it will not try using EPSV. | ||
| --auto-initAutomatically run init action when running push action | ||
| --deployedsha1file The name of the file that keeps the SHA1 hash of the current git commit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The formatting is a bit off here.
…ne and through config
This is a PR in response to issue:#604
It passes local tests (I did not write any additional). I don't think there's a need to update any man pages nor docs.