- Notifications
You must be signed in to change notification settings - Fork14.1k
[WIP] Cross Entropy Loss on Metal#18121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
iliailmer wants to merge4 commits intoggml-org:masterChoose a base branch fromiliailmer:cross-entropy-loss-metal
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Draft
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Member
ggerganov commentedDec 17, 2025
There was a PR in ggml recently:ggml-org/ggml#1390 Might want to help with reviewing/improving that instead. |
ContributorAuthor
iliailmer commentedDec 18, 2025
should i go ahead and close this one? |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
Apple Metalhttps://en.wikipedia.org/wiki/Metal_(API) ggmlchanges relating to the ggml tensor library for machine learning
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains Metal implementation of cross entropy loss.
Make sure to read thecontributing guidelines before submitting a PR