- Notifications
You must be signed in to change notification settings - Fork13.9k
Add a couple of file types to the text section#17670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Conversation
allozaur left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@pwilkin looking good in general.
Please runnpm run format for linting CI to pass + please update the static build :)
pwilkin commentedDec 2, 2025
Just when I was getting used to running |
allozaur commentedDec 2, 2025
Did you run |
pwilkin commentedDec 2, 2025
Nope, just npm run build :> |
allozaur commentedDec 2, 2025
Busted! 😝 lemme know when you have formatted the code and maybe add a short test video to the PR description? 😊 |
Fixes#17556
I believe we should at least support the source files in the llama.cpp codebase ;)