Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

chore: omitempty metadata to reduce the size of stored config#1571

Open
cgetzen wants to merge1 commit intogetsops:main
base:main
Choose a base branch
Loading
fromcgetzen-forks:cg/minimum-sops-config

Conversation

cgetzen
Copy link

@cgetzencgetzen commentedJul 31, 2024
edited
Loading

This reduces the sops configuration stored in files to its bare minimum:

# example with GCP KMSsomeConfig:...sops:gcp_kms:        -resource_id:projects/some-project/locations/global/keyRings/some-keyring/cryptoKeys/some-keycreated_at:"2024-08-31T01:09:49Z"enc:someenc=lastmodified:"2024-08-31T21:53:36Z"mac:ENC[AES256_GCM,data:/somemac=,tag:sometag==,type:str]encrypted_regex:someregexmac_only_encrypted:trueversion:3.9.0

Signed-off-by: Charlie Getzen <charlie_g@regrello.com>
@cgetzencgetzenforce-pushed thecg/minimum-sops-config branch fromd10331a to246efdeCompareJuly 31, 2024 22:02
@cgetzencgetzen changed the titlechore: omitempty optional metadata to reduce the size of stored configchore: omitempty metadata to reduce the size of stored configAug 2, 2024
@felixfontein
Copy link
Contributor

While this is nice, it's also causing a lot of changes to exisitng SOPS-encrypted files when these are changed (edited, keys updated, rotated, etc.).

@getsops/maintainers we have to figure out when to include this (it definitely should not go into a bugfix release) - assuming nobody objects to having this at all?

@cgetzen
Copy link
Author

Thanks for the review@felixfontein. What do you think about adding the3.10 label so that it could make it into the next minor version?

@felixfontein
Copy link
Contributor

@cgetzen I added it to the Discussion milestone so it can be moved to the appropriate milestone once it has been discussed. (GitHub only allows to assign one milestone, so adding the 3.10 milestone will remove the Discussion milestone.)

cgetzen reacted with thumbs up emoji

@cgetzen
Copy link
Author

@felixfontein I'm curious what qualities would prevent this from going out in a minor release? It is backwards compatible.

@felixfontein
Copy link
Contributor

I think having it in a new minor release is fine, but I'd like to hear opinions from the other maintainers as well. This is potentially creating larger diffs for users, that could be a reason to wait for a new major release.

@felixfontein
Copy link
Contributor

Ping @getsops/maintainers

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
@cgetzen@felixfontein

[8]ページ先頭

©2009-2025 Movatter.jp