- Notifications
You must be signed in to change notification settings - Fork919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
chore: omitempty metadata to reduce the size of stored config#1571
base:main
Are you sure you want to change the base?
Conversation
Signed-off-by: Charlie Getzen <charlie_g@regrello.com>
d10331a
to246efde
CompareWhile this is nice, it's also causing a lot of changes to exisitng SOPS-encrypted files when these are changed (edited, keys updated, rotated, etc.). @getsops/maintainers we have to figure out when to include this (it definitely should not go into a bugfix release) - assuming nobody objects to having this at all? |
Thanks for the review@felixfontein. What do you think about adding the3.10 label so that it could make it into the next minor version? |
@cgetzen I added it to the Discussion milestone so it can be moved to the appropriate milestone once it has been discussed. (GitHub only allows to assign one milestone, so adding the 3.10 milestone will remove the Discussion milestone.) |
@felixfontein I'm curious what qualities would prevent this from going out in a minor release? It is backwards compatible. |
I think having it in a new minor release is fine, but I'd like to hear opinions from the other maintainers as well. This is potentially creating larger diffs for users, that could be a reason to wait for a new major release. |
Ping @getsops/maintainers |
This reduces the sops configuration stored in files to its bare minimum: