- Notifications
You must be signed in to change notification settings - Fork920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Update rustc functional tests to v1.70.0#1234
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
18ade9b toc75edd8CompareBear minimum to get this going again, including an update ofdependencies.It's worth noting that there is a detachment between the GitHub Actionworkflow and running this locally. As there are assumptions around:1. Having the `pgp/sops_functional_tests_key.asc` imported.2. Having a Vault server running for two functional tests.The `functional-tests` Make target does not facilitate this, andputting something in place using a temporary `GNUPGHOME` and acontainer image would likely be a welcome future improvement.In addition, there is Rust code in `validation/` which appears to be anartifact from an ancient Python library[1][2]. This should probably beremoved in the future.[1]:https://github.com/getsops/sops/tree/python-sops[2]:https://pypi.org/project/sops/Signed-off-by: Hidde Beydals <hidde@hhh.computer>
devstein approved these changesJul 2, 2023
hiddeco added a commit that referenced this pull requestJul 11, 2023
This appears to be a 7 year old, unmaintained, unused, artifact fromaround the time things were still written in Python. As observedearlier in#1234.As this now actively triggers a security warning due to an outdateddependency, remove it.Signed-off-by: Hidde Beydals <hidde@hhh.computer>
kaedwen pushed a commit to kaedwen/sops that referenced this pull requestNov 15, 2023
This appears to be a 7 year old, unmaintained, unused, artifact fromaround the time things were still written in Python. As observedearlier ingetsops#1234.As this now actively triggers a security warning due to an outdateddependency, remove it.Signed-off-by: Hidde Beydals <hidde@hhh.computer>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bear minimum to get this going again, including an update of
dependencies.
It's worth noting that there is a detachment between the GitHub Action
workflow and running this locally. As there are assumptions around:
pgp/sops_functional_tests_key.ascimported.The
functional-testsMake target does not facilitate this, andputting something in place using a temporary
GNUPGHOMEand acontainer image would likely be a welcome future improvement.
In addition, there is Rust code in
validation/which appears to be anartifact from an ancient Python library1. This should probably be
removed in the future.