…ration- Add support for multiple framework/bundler-specific environment variables with proper precedence  - SENTRY_SPOTLIGHT (highest priority - base name, supported natively by many bundlers)  - PUBLIC_SENTRY_SPOTLIGHT (SvelteKit, Astro, Qwik)  - NEXT_PUBLIC_SENTRY_SPOTLIGHT (Next.js)  - VITE_SENTRY_SPOTLIGHT (Vite)  - NUXT_PUBLIC_SENTRY_SPOTLIGHT (Nuxt.js)  - REACT_APP_SENTRY_SPOTLIGHT (Create React App)  - VUE_APP_SENTRY_SPOTLIGHT (Vue CLI)  - GATSBY_SENTRY_SPOTLIGHT (Gatsby)- Add defensive environment variable access via process.env (transformed by all major bundlers)- Move envToBool utility from node-core to core for shared usage- Add resolveSpotlightOptions utility for consistent precedence rules- Update node-core and aws-serverless to use shared utilities- Add comprehensive tests for all new utilities and SDK integrationNote: import.meta.env is intentionally not checked because bundlers only replace staticreferences (e.g., import.meta.env.VITE_VAR) at build time, not dynamic access. All majorbundlers transform process.env references, making it the universal solution.

Before submitting a pull request, please take a look at our[Contributing](https://github.com/getsentry/sentry-javascript/blob/master/CONTRIBUTING.md)guidelines and verify:- [x] If you've added code that should be tested, please add tests.- [x] Ensure your code lints and the test suite passes (`yarn lint`) &(`yarn test`).Fixes a test failure where `getSpotlightConfig` was returning empty orwhitespace-only strings for `SENTRY_SPOTLIGHT` environment variables,instead of `undefined`. This change explicitly filters out such values,aligning the function's behavior with test expectations and preventinginvalid Spotlight configurations.---<ahref="https://cursor.com/background-agent?bcId=bc-88bd0365-3796-47b2-bb84-29c93d0430e8"><picture><sourcemedia="(prefers-color-scheme: dark)"srcset="https://cursor.com/open-in-cursor-dark.svg"><sourcemedia="(prefers-color-scheme: light)"srcset="https://cursor.com/open-in-cursor-light.svg"><img alt="Open inCursor"src="https://cursor.com/open-in-cursor.svg"></picture></a>&nbsp;<ahref="https://cursor.com/agents?id=bc-88bd0365-3796-47b2-bb84-29c93d0430e8"><picture><sourcemedia="(prefers-color-scheme: dark)"srcset="https://cursor.com/open-in-web-dark.svg"><sourcemedia="(prefers-color-scheme: light)"srcset="https://cursor.com/open-in-web-light.svg"><img alt="Open in Web"src="https://cursor.com/open-in-web.svg"></picture></a>---------Co-authored-by: Cursor Agent <cursoragent@cursor.com>

Lms24 left a comment

Before submitting a pull request, please take a look at our[Contributing](https://github.com/getsentry/sentry-javascript/blob/master/CONTRIBUTING.md)guidelines and verify:- [x] If you've added code that should be tested, please add tests.- [x] Ensure your code lints and the test suite passes (`yarn lint`) &(`yarn test`).---This PR addresses critical feedback regarding environment variabledetection, particularly for Vite-based frameworks.**Key Changes:*** **`packages/browser/src/utils/env.ts`**: The `getEnvValue` functionnow checks both `process.env` (for Webpack, Next.js, CRA) and`import.meta.env` (for Vite, Astro, SvelteKit). This ensures thatenvironment variables (like those for Spotlight) are correctly detectedacross a wider range of bundlers and frameworks, fixing a significantcompatibility issue.* **`packages/browser/test/utils/env.test.ts`**: Updated unit tests tofocus on `process.env` scenarios. Added a note explaining that`import.meta.env` cannot be unit tested due to its read-only,compile-time nature and is covered by e2e tests.* **`packages/browser/src/utils/spotlightConfig.ts`**: Added a commentto clarify the explicit `return undefined` for readability, noting itsoptimization in production builds.---<ahref="https://cursor.com/background-agent?bcId=bc-d6001dc9-59fc-42eb-8354-a573e3ae71a9"><picture><sourcemedia="(prefers-color-scheme: dark)"srcset="https://cursor.com/open-in-cursor-dark.svg"><sourcemedia="(prefers-color-scheme: light)"srcset="https://cursor.com/open-in-cursor-light.svg"><img alt="Open inCursor"src="https://cursor.com/open-in-cursor.svg"></picture></a>&nbsp;<ahref="https://cursor.com/agents?id=bc-d6001dc9-59fc-42eb-8354-a573e3ae71a9"><picture><sourcemedia="(prefers-color-scheme: dark)"srcset="https://cursor.com/open-in-web-dark.svg"><sourcemedia="(prefers-color-scheme: light)"srcset="https://cursor.com/open-in-web-light.svg"><img alt="Open in Web"src="https://cursor.com/open-in-web.svg"></picture></a>Co-authored-by: Cursor Agent <cursoragent@cursor.com>

timfish left a comment

cursorbot left a comment

Instead of just filtering old events, actually remove them from the buffer.This prevents stale events from ever being matched by future listeners,even if timestamps are somehow compared incorrectly.Events older than the listener registration time are definitely staleand will never be needed by any listener.

- Add @spotlightjs/spotlight dependency to test-utils- Create spotlight.ts with startSpotlight() and event waiting helpers- Add Spotlight mode to getPlaywrightConfig() via useSpotlight option- Migrate react-router-7-lazy-routes test app as proof of concept  - Use DSN workaround (http://spotlight@localhost:8969/0)  - Remove custom event proxy in favor of Spotlight  - Update tests to use waitForSpotlightTransactionThis migration eliminates the custom event proxy server which hadtiming issues causing flaky tests. Spotlight provides a more robustsolution for capturing and streaming Sentry events during E2E tests.

The buffer pruning condition (<=) was inconsistent with the live eventsending condition (>=). This meant buffered events at exactly the samemillisecond as listener registration would be incorrectly pruned, eventhough live events at the same timestamp would be sent.With millisecond timestamps, same-timestamp collisions are more likely,which could cause intermittent test failures. Changed to strict < tomatch the >= behavior for live events.

…y-server.ts- Add null check for portMatch[1] in spotlight.ts- Add null check for eventBuffer element in generator- Refactor buffer pruning loop to avoid 'possibly undefined' error

…ciesInstalling Spotlight in individual test apps causes version conflictsbecause Spotlight's transitive dependencies (e.g. @sentry/electron)require specific @sentry/* versions that conflict with the freshlybuilt packages used by E2E tests.Moving to root devDependencies avoids this conflict - the Spotlight CLIis available globally without polluting test app dependency trees.

Reverting all timestamp/buffer filtering changes as they were breakingother tests. The original implementation will be kept until theSpotlight migration is complete.

The Spotlight approach had a fundamental architecture issue:- Playwright's webServer spawns Spotlight as a separate process- Tests run in the Playwright test runner process- The event buffer in spotlight.ts only gets populated if startSpotlight()  is called in the same process as the tests- Since they're different processes, the buffer is always emptyKeeping spotlight.ts for future use but marking exports as experimental.The test app is reverted to use the original event proxy approach.

Instead of using Playwright's webServer to spawn Spotlight (which runsin a separate process and can't share the event buffer), tests now callstartSpotlight() directly in beforeAll hooks.This way:- Test process spawns Spotlight via `spotlight run -f json`- Spotlight auto-runs the app and streams events to stdout- Test process parses stdout and populates the event buffer- waitForSpotlightTransaction() works because it's in the same processChanges:- playwright.config.mjs: Empty webServer (Spotlight handles app startup)- src/index.tsx: Use Spotlight DSN workaround instead of tunnel- tests/*.ts: Add beforeAll/afterAll for Spotlight lifecycle- Deleted start-event-proxy.mjs (no longer needed)

Test apps are copied to a temp directory during CI, so they don't haveaccess to the root's node_modules where @spotlightjs/spotlight isinstalled. Using npx will use the installed version if available ordownload it if needed, working regardless of the package manager.

- Find monorepo root by looking for package.json with workspaces- Use spotlight binary from root's node_modules/.bin/- Fix regex to match 'Spotlight listening on PORT' format- Resolve immediately when listening message detectedTested locally - startSpotlight correctly detects port and starts.

Use import.meta.url in ESM environments and __dirname in CJS.This fixes the ReferenceError when tests run as ES modules.

- Remove unused eslint-disable directive- Type JSON.parse result properly- Add null check for stdout/stderr instead of non-null assertions

…ight- Pass PORT env var to Spotlight so app runs on expected port (3030)- Add appPort option to SpotlightOptions (defaults to 3030)- Poll app's HTTP endpoint to confirm it's ready before resolving- This fixes ERR_CONNECTION_REFUSED errors in tests

…losure

The app's DSN is hardcoded to http://spotlight@localhost:8969/0so Spotlight must use the same port to receive events.