Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork227
fix: Generate and inject uuid to apk and upload proguard with that uuid#4532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
fix: Generate and inject uuid to apk and upload proguard with that uuid#4532
Uh oh!
There was an error while loading.Please reload this page.
Conversation
codecovbot commentedSep 16, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## main #4532 +/- ##==========================================- Coverage 73.37% 73.36% -0.02%========================================== Files 479 479 Lines 17505 17505 Branches 3445 3445 ==========================================- Hits 12844 12842 -2- Misses 3783 3784 +1- Partials 878 879 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
alexsohn1126 commentedSep 17, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Looks like there is an endpoint for proguard artifact upload that is not implemented in sentry-cli integration tests server. In other integration test servers, they have endpoints for
I'll make a PR over at Doesn't seem too hard to make it, what can possibly go wrong 🫨 |
alexsohn1126 commentedSep 17, 2025
Actually, it's kind of weird that we are getting errors from uploading proguards now but we weren't before? Maybe something's up with my implementation, but from what I can see, it doesn't touch the condition which the proguard file is sent so... |
alexsohn1126 commentedSep 17, 2025
Blocked bygetsentry/github-workflow #100 |
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: Stefan Pölz <38893694+Flash0ver@users.noreply.github.com>
jamescrosswell left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks good - thanks@alexsohn1126 !
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
fixes#3872
Problem
We were not automatically injecting uuid to the MAUI Android apk, so developers would have to manually go in and edit
AndroidManifest.xml.Solution
As proposed by@rafalka, we can inject the uuid to the Apk, and upload the proguard file with the same uuid.
Before
Before the fix, running in the MAUI project would upload the proguard file with the uuid, but it won't inject the uuid to the Android app.
After
We should now see the proguard file in Sentry with some uuid:
If we open the resulting APK in Android studio to inspect it's
AndroidManifest.xml, we can see that it correctly set themeta-datafield:Testing method
To test this change using our
samples/Sentry.Samples.Maui, we need to modifysrc/Sentry/buildTransitive/Sentry.targetsfile. If not using our sample MAUI project, ignore this step.We have to remove the check whether this is a Sentry project or not. So delete the
and [...]in line 72-73:sentry-dotnet/src/Sentry/buildTransitive/Sentry.targets
Lines 69 to 73 in7061fb9
Next, ensure
SentryUploadAndroidProguardMappingis set to true in your MAUI project's .csproj file:In the same file, enable Proguard. This is what I used:
Run
dotnet publish -f net9.0-android35.0 -c Releasein the MAUI project root.