Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

templates: add optional Series ID buttons to the patch list#571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
rossburton wants to merge1 commit intogetpatchwork:main
base:main
Choose a base branch
Loading
fromrossburton:patchlist-copy

Conversation

@rossburton
Copy link
Contributor

@rossburtonrossburton commentedNov 21, 2023
edited
Loading

If the user has turned on display of patch IDs, add another column with the series IDs to the patch list template.

Note that I've not tested this in production because I've not yet setup a local instance...

@rossburton
Copy link
ContributorAuthor

Now tested!

Had to use a nbsp to stop "Series ID" wrapping and ruining the header alignment.

Screenshot 2023-11-22 at 01 32 52

@rossburton
Copy link
ContributorAuthor

I'm torn on whether the column should just be called "ID" and let its position clarifywhat ID it refers to.

@rossburton
Copy link
ContributorAuthor

Maybe the ID column should just be removed, and the button inline with the patch or series name?

@stephenfin
Copy link
Member

I wonder if, rather than adding another column, we could add the<button> in the existing series column, before the subject? Every bit as clickable but we avoid adding yet more columns to the rather large table.

If the user has turned on display of patch IDs, add clickable series IDbuttons inline with the series name.Signed-off-by: Ross Burton <ross.burton@arm.com>
@rossburton
Copy link
ContributorAuthor

Done.

Screenshot 2024-01-25 at 11 59 03

Would it be sensible to merge the "Patch ID" and "Patch" columns too?

@rossburton
Copy link
ContributorAuthor

rossburton commentedJan 25, 2024
edited
Loading

The good thing about two columns is it forces the alignment...

@rossburton
Copy link
ContributorAuthor

Polite ping

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rossburton@stephenfin

[8]ページ先頭

©2009-2025 Movatter.jp