Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork180
perf: Cache snippets#7369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:develop-minor
Are you sure you want to change the base?
perf: Cache snippets#7369
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| // start with a fresh version cache | ||
| // start with a fresh snippet and version cache | ||
| Snippet::resetCache(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This will not work when someone replaces the snippet component with their own class. Have to think of an alternative.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@bastianallgeier Do you see any way with the currentsnippet core component implementation to find out fromKirby\Cms\App what class is used for snippets?
Description
Avoid repeated
F::exists()and extension calls when using the same snippets within the requestChangelog
Performance
Ready?
For review team